Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299194: CustomTzIDCheckDST.java may fail at future date #1140

Closed
wants to merge 1 commit into from

Conversation

takiguc
Copy link

@takiguc takiguc commented Feb 1, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299194: CustomTzIDCheckDST.java may fail at future date

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1140/head:pull/1140
$ git checkout pull/1140

Update a local copy of the PR:
$ git checkout pull/1140
$ git pull https://git.openjdk.org/jdk17u-dev pull/1140/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1140

View PR using the GUI difftool:
$ git pr show -t 1140

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1140.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2023

👋 Welcome back itakiguchi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5e2de89628aaf6acb8e458fb417426ca5e477bea 8299194: CustomTzIDCheckDST.java may fail at future date Feb 1, 2023
@openjdk
Copy link

openjdk bot commented Feb 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 1, 2023

@takiguc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299194: CustomTzIDCheckDST.java may fail at future date

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2023

Webrevs

@takiguc
Copy link
Author

takiguc commented Feb 4, 2023

jdk17u-fix-yes is verified

/integrate

@openjdk
Copy link

openjdk bot commented Feb 4, 2023

Going to push as commit 0ed3689.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 2fa09bb: 8290836: Improve test coverage for XPath functions: String Functions
  • fe770e3: 8299296: Write a test to verify the components selection sends ItemEvent
  • 38eb0d6: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows
  • 012a216: 8289400: Improve com/sun/jdi/TestScaffold error reporting
  • c74eb2b: 8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
  • 78c6be2: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases
  • 50c3433: 8291825: java/time/nontestng/java/time/zone/CustomZoneNameTest.java fails if defaultLocale and defaultFormatLocale are different
  • a3f2288: 8286844: com/sun/jdi/RedefineCrossEvent.java failed with 1 threads completed while VM suspended
  • 7224cbe: 8287593: ShortResponseBody could be made more resilient to rogue connections
  • 83c0805: 8289948: Improve test coverage for XPath functions: Node Set Functions
  • ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/501a4bf95b1d1bb4c942f6a36dca38ca7aaaba34...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 4, 2023
@openjdk openjdk bot closed this Feb 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 4, 2023
@openjdk
Copy link

openjdk bot commented Feb 4, 2023

@takiguc Pushed as commit 0ed3689.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant