8294677: chunklevel::MAX_CHUNK_WORD_SIZE too small for some applications

[tstuefe]

Downport is not clean. Patch did not merge cleanly, but only due to trivial comment changes introduced with "8273783: Simplify Metaspace arena guard handling" in test/hotspot/gtest/metaspace/test_metaspace_misc.cpp . I don't plan to downport 8273783.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294677: chunklevel::MAX_CHUNK_WORD_SIZE too small for some applications

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Xin Liu (@navyxliu - no project role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1142/head:pull/1142
$ git checkout pull/1142

Update a local copy of the PR:
$ git checkout pull/1142
$ git pull https://git.openjdk.org/jdk17u-dev pull/1142/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1142

View PR using the GUI difftool:
$ git pr show -t 1142

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1142.diff

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (d2a2f67f)

[phohensee]

Lgtm.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294677: chunklevel::MAX_CHUNK_WORD_SIZE too small for some applications

Reviewed-by: phh, xliu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 83c0805: 8289948: Improve test coverage for XPath functions: Node Set Functions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[navyxliu]

LGTM.

I think this patch is safe. It horizontally extends the maximal chunk of metaspace from 4M to 16M. The only side effect is that the updated jdk increases the reserve space for MetaSpace from 8Mb to 16Mb on LP32 systems. It's fine.

[tstuefe]

Tested:

• manually ran hotspot_metaspace on x64 and x86
• SAP nightlies
• GHAs
• I also manually tested x64 to check that we don't have a memory usage regression.

[tstuefe]

/integrate

[openjdk]

Going to push as commit ddd9631.
Since your change was applied there have been 11 commits pushed to the master branch:

• 0ed3689: 8299194: CustomTzIDCheckDST.java may fail at future date
• 2fa09bb: 8290836: Improve test coverage for XPath functions: String Functions
• fe770e3: 8299296: Write a test to verify the components selection sends ItemEvent
• 38eb0d6: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows
• 012a216: 8289400: Improve com/sun/jdi/TestScaffold error reporting
• c74eb2b: 8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
• 78c6be2: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases
• 50c3433: 8291825: java/time/nontestng/java/time/zone/CustomZoneNameTest.java fails if defaultLocale and defaultFormatLocale are different
• a3f2288: 8286844: com/sun/jdi/RedefineCrossEvent.java failed with 1 threads completed while VM suspended
• 7224cbe: 8287593: ShortResponseBody could be made more resilient to rogue connections
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/b9e4d10ce9304991880bd502a1bbefb729d9a39f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit ddd9631.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.