-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8290836: Improve test coverage for XPath functions: String Functions #1143
Conversation
8290837: Improve test coverage for XPath functions: Boolean Functions 8290838: Improve test coverage for XPath functions: Number Functions Reviewed-by: joehw (cherry picked from commit d889264c6123b6c28bdd6336f5ae547e4e441aa7)
👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issues from the original commit. |
@Rudometov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@Rudometov |
https://bugs.openjdk.org/browse/JDK-8290837 is tagged jdk17u-fix-yes, but https://bugs.openjdk.org/browse/JDK-8290836 (this PR) and https://bugs.openjdk.org/browse/JDK-8290838 were included in the same original commit but are not tagged. This PR will backport all three. |
/sponsor |
Going to push as commit 2fa09bb.
Your commit was automatically rebased without conflicts. |
@phohensee @Rudometov Pushed as commit 2fa09bb. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport for
https://bugs.openjdk.org/browse/JDK-8290836 Improve test coverage for XPath functions: String Functions
https://bugs.openjdk.org/browse/JDK-8290837 Improve test coverage for XPath functions: Boolean Functions
https://bugs.openjdk.org/browse/JDK-8290838 Improve test coverage for XPath functions: Number Functions
cherry picked from commit d889264c6123b6c28bdd6336f5ae547e4e441aa7 ()
Clean backport, parity with 17.0.8-oracle
Low risk, test update and new test
Test passes on linux, macOS
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1143/head:pull/1143
$ git checkout pull/1143
Update a local copy of the PR:
$ git checkout pull/1143
$ git pull https://git.openjdk.org/jdk17u-dev pull/1143/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1143
View PR using the GUI difftool:
$ git pr show -t 1143
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1143.diff