Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290836: Improve test coverage for XPath functions: String Functions #1143

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Feb 2, 2023

Backport for
https://bugs.openjdk.org/browse/JDK-8290836 Improve test coverage for XPath functions: String Functions
https://bugs.openjdk.org/browse/JDK-8290837 Improve test coverage for XPath functions: Boolean Functions
https://bugs.openjdk.org/browse/JDK-8290838 Improve test coverage for XPath functions: Number Functions

cherry picked from commit d889264c6123b6c28bdd6336f5ae547e4e441aa7 ()

Clean backport, parity with 17.0.8-oracle
Low risk, test update and new test

Test passes on linux, macOS


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8290836: Improve test coverage for XPath functions: String Functions
  • JDK-8290837: Improve test coverage for XPath functions: Boolean Functions
  • JDK-8290838: Improve test coverage for XPath functions: Number Functions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1143/head:pull/1143
$ git checkout pull/1143

Update a local copy of the PR:
$ git checkout pull/1143
$ git pull https://git.openjdk.org/jdk17u-dev pull/1143/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1143

View PR using the GUI difftool:
$ git pr show -t 1143

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1143.diff

8290837: Improve test coverage for XPath functions: Boolean Functions
8290838: Improve test coverage for XPath functions: Number Functions

Reviewed-by: joehw
(cherry picked from commit d889264c6123b6c28bdd6336f5ae547e4e441aa7)
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 2, 2023

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d889264c6123b6c28bdd6336f5ae547e4e441aa7 8290836: Improve test coverage for XPath functions: String Functions Feb 2, 2023
@openjdk
Copy link

openjdk bot commented Feb 2, 2023

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 2, 2023

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290836: Improve test coverage for XPath functions: String Functions
8290837: Improve test coverage for XPath functions: Boolean Functions
8290838: Improve test coverage for XPath functions: Number Functions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 38eb0d6: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows
  • 012a216: 8289400: Improve com/sun/jdi/TestScaffold error reporting
  • c74eb2b: 8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
  • 78c6be2: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases
  • 50c3433: 8291825: java/time/nontestng/java/time/zone/CustomZoneNameTest.java fails if defaultLocale and defaultFormatLocale are different
  • a3f2288: 8286844: com/sun/jdi/RedefineCrossEvent.java failed with 1 threads completed while VM suspended
  • 7224cbe: 8287593: ShortResponseBody could be made more resilient to rogue connections

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 2, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 2, 2023

Webrevs

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 3, 2023
@openjdk
Copy link

openjdk bot commented Feb 3, 2023

@Rudometov
Your change (at version a230d3a) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

https://bugs.openjdk.org/browse/JDK-8290837 is tagged jdk17u-fix-yes, but https://bugs.openjdk.org/browse/JDK-8290836 (this PR) and https://bugs.openjdk.org/browse/JDK-8290838 were included in the same original commit but are not tagged. This PR will backport all three.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 3, 2023

Going to push as commit 2fa09bb.
Since your change was applied there have been 8 commits pushed to the master branch:

  • fe770e3: 8299296: Write a test to verify the components selection sends ItemEvent
  • 38eb0d6: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows
  • 012a216: 8289400: Improve com/sun/jdi/TestScaffold error reporting
  • c74eb2b: 8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
  • 78c6be2: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases
  • 50c3433: 8291825: java/time/nontestng/java/time/zone/CustomZoneNameTest.java fails if defaultLocale and defaultFormatLocale are different
  • a3f2288: 8286844: com/sun/jdi/RedefineCrossEvent.java failed with 1 threads completed while VM suspended
  • 7224cbe: 8287593: ShortResponseBody could be made more resilient to rogue connections

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 3, 2023
@openjdk openjdk bot closed this Feb 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 3, 2023
@openjdk
Copy link

openjdk bot commented Feb 3, 2023

@phohensee @Rudometov Pushed as commit 2fa09bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants