Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx #1146

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 6, 2023

II backport this for parity with 17.0.7-oracle.

I had to resolve.
ProblemList: not listed for macosx-aarch64.
The @run command differed, removed IgnoreUnrecognizedOptions jin addition.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx
  • JDK-8241293: CompressedClassSpaceSizeInJmapHeap.java time out after 8 minutes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1146/head:pull/1146
$ git checkout pull/1146

Update a local copy of the PR:
$ git checkout pull/1146
$ git pull https://git.openjdk.org/jdk17u-dev pull/1146/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1146

View PR using the GUI difftool:
$ git pr show -t 1146

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1146.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 6, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 99a6c47855ad82e81a80726cf3aa4522c547716d 8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx Feb 6, 2023
@openjdk
Copy link

openjdk bot commented Feb 6, 2023

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 6, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 6, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Feb 6, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx
8241293: CompressedClassSpaceSizeInJmapHeap.java time out after 8 minutes

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 4ab869e: 8296329: jar validator doesn't account for minor class file version
  • ceabaee: 8300590: [JVMCI] BytecodeFrame.equals is broken

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 6, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Feb 7, 2023

Pre-submit failure: "Unable to connect to azure.archive.ubuntu.com:http"
Unrelated. Won't rerun this, the builds are not necessary to show this test-only
fix works. It passed SAP internal testing.

@GoeLin
Copy link
Member Author

GoeLin commented Feb 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 8, 2023

Going to push as commit a15041a.
Since your change was applied there have been 3 commits pushed to the master branch:

  • beaf5b1: 8286962: java/net/httpclient/ServerCloseTest.java failed once with ConnectException
  • 4ab869e: 8296329: jar validator doesn't account for minor class file version
  • ceabaee: 8300590: [JVMCI] BytecodeFrame.equals is broken

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 8, 2023
@openjdk openjdk bot closed this Feb 8, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Feb 8, 2023
@GoeLin GoeLin deleted the goetz_backport_8298073 branch February 8, 2023 16:08
@openjdk openjdk bot removed the rfr Pull request is ready for review label Feb 8, 2023
@openjdk
Copy link

openjdk bot commented Feb 8, 2023

@GoeLin Pushed as commit a15041a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants