Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270859: Post JEP 411 refactoring: client libs with maximum covering > 10K #1148

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Feb 9, 2023

Hi all,
This pull request contains a backport of commit 90cd2fa1 from the openjdk/jdk repository.
The commit being backported was authored by Weijun Wang on 27 Jul 2021 and was reviewed by Sergey Bylokhov.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8270859: Post JEP 411 refactoring: client libs with maximum covering > 10K

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1148/head:pull/1148
$ git checkout pull/1148

Update a local copy of the PR:
$ git checkout pull/1148
$ git pull https://git.openjdk.org/jdk17u-dev pull/1148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1148

View PR using the GUI difftool:
$ git pr show -t 1148

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1148.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 90cd2fa16458dcc3e36171fa4bf21f26bc92b168 8270859: Post JEP 411 refactoring: client libs with maximum covering > 10K Feb 9, 2023
@openjdk
Copy link

openjdk bot commented Feb 9, 2023

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review February 21, 2023 22:21
@openjdk
Copy link

openjdk bot commented Feb 21, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270859: Post JEP 411 refactoring: client libs with maximum covering > 10K

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • da62b2b: 8299970: Speed up compiler/arraycopy/TestArrayCopyConjoint.java
  • fcd9110: 8298472: AArch64: Detect Ampere-1 and Ampere-1A CPUs and set default options
  • a6f4cf1: 8302152: Speed up tests with infinite loops, sleep less
  • 49ff97c: 8301342: Prefer ArrayList to LinkedList in LayoutComparator
  • 5027f56: 8288332: Tier1 validate-source fails after 8279614
  • d0e0633: 8302692: [17u] Update GHA Boot JDK to 17.0.6
  • fb6d6fe: 8301842: JFR: increase checkpoint event size for stacktrace and string pool
  • cf5490b: 8297437: javadoc cannot link to old docs (with old style anchors)
  • 334ec9a: 8282958: Rendering Issues with Borders on Windows High-DPI systems
  • d2409a7: 8295777: java/net/httpclient/ConnectExceptionTest.java should not rely on system resolver
  • ... and 22 more: https://git.openjdk.org/jdk17u-dev/compare/a15041a232d1ba273dd7366f35da674381a01688...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 21, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Mar 13, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 13, 2023

Going to push as commit c118b0e.
Since your change was applied there have been 52 commits pushed to the master branch:

  • 1ad9e68: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures
  • 1cad49b: 8303433: Bump update version for OpenJDK: jdk-17.0.8
  • 9b054a1: 8289511: Improve test coverage for XPath Axes: child
  • ca049ec: 8284524: Create an automated test for JDK-4422362
  • fd93a6a: 8284767: Create an automated test for JDK-4422535
  • 181a7bb: 8210927: JDB tests do not update source path after doing a redefine class
  • bf51354: 8048190: NoClassDefFoundError omits original ExceptionInInitializerError
  • 7b967bf: 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension
  • 58b479b: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails
  • ae1a3b4: 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316
  • ... and 42 more: https://git.openjdk.org/jdk17u-dev/compare/a15041a232d1ba273dd7366f35da674381a01688...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 13, 2023
@openjdk openjdk bot closed this Mar 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 13, 2023
@openjdk
Copy link

openjdk bot commented Mar 13, 2023

@mrserb Pushed as commit c118b0e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant