Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286030: Avoid JVM crash when containers share the same /tmp dir #1150

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 9, 2023

I backport this for parity with 17.0.7-oracle.

I had to resolve due to context in perfMemory_posix.cpp.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286030: Avoid JVM crash when containers share the same /tmp dir

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1150/head:pull/1150
$ git checkout pull/1150

Update a local copy of the PR:
$ git checkout pull/1150
$ git pull https://git.openjdk.org/jdk17u-dev pull/1150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1150

View PR using the GUI difftool:
$ git pr show -t 1150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1150.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 84f23149e22561173feb0e34bca31a7345b43c89 8286030: Avoid JVM crash when containers share the same /tmp dir Feb 9, 2023
@openjdk
Copy link

openjdk bot commented Feb 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 9, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286030: Avoid JVM crash when containers share the same /tmp dir

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 9, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 9, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Feb 10, 2023

Pre-submit failures: During jtreg build [ERROR] wget exited with exit code 8.
Unrelated. Trivial change, no rerun necessary.

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

This test should be tested in our nightlies.

@GoeLin
Copy link
Member Author

GoeLin commented Feb 10, 2023

Thanks for the review! Yes, it ran in our nightlies without errors.

@GoeLin
Copy link
Member Author

GoeLin commented Feb 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 10, 2023

Going to push as commit d52e18c.
Since your change was applied there have been 4 commits pushed to the master branch:

  • b023d5c: 8290083: ResponseBodyBeforeError: AssertionError or SSLException: Unsupported or unrecognized SSL message
  • cb1a54a: 8195809: [TESTBUG] jps and jcmd -l support for containers is not tested
  • 3330f9c: 8301170: perfMemory_windows.cpp add free_security_attr to early returns
  • 651ec7d: 8301760: Fix possible leak in SpNegoContext dispose

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 10, 2023
@openjdk openjdk bot closed this Feb 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 10, 2023
@openjdk
Copy link

openjdk bot commented Feb 10, 2023

@GoeLin Pushed as commit d52e18c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8286030 branch February 10, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants