Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295774: Write a test to verify List sends ItemEvent/ActionEvent #1158

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 9, 2023

I backport this for parity with 17.0.7-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295774: Write a test to verify List sends ItemEvent/ActionEvent

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1158/head:pull/1158
$ git checkout pull/1158

Update a local copy of the PR:
$ git checkout pull/1158
$ git pull https://git.openjdk.org/jdk17u-dev pull/1158/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1158

View PR using the GUI difftool:
$ git pr show -t 1158

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1158.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2a79dfc1f9c419e92aac99f92ef4e40a3471695b 8295774: Write a test to verify List sends ItemEvent/ActionEvent Feb 9, 2023
@openjdk
Copy link

openjdk bot commented Feb 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 9, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295774: Write a test to verify List sends ItemEvent/ActionEvent

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 9, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 9, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Feb 10, 2023

Pre-submit tests not finished. I'd like to push anyways, the missing tests are not meaningful to this change.

@GoeLin
Copy link
Member Author

GoeLin commented Feb 12, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 12, 2023

Going to push as commit fab9770.
Since your change was applied there have been 9 commits pushed to the master branch:

  • a248b78: 8295000: java/util/Formatter/Basic test cleanup
  • 5bef90f: 8296675: Exclude linux-aarch64 in NSS tests
  • 1b5825c: 8292328: AccessibleActionsTest.java test instruction for show popup on JLabel did not specify shift key
  • 49023f4: 8293819: sun/util/logging/PlatformLoggerTest.java failed with "RuntimeException: Retrieved backing PlatformLogger level null is not the expected CONFIG"
  • d52e18c: 8286030: Avoid JVM crash when containers share the same /tmp dir
  • b023d5c: 8290083: ResponseBodyBeforeError: AssertionError or SSLException: Unsupported or unrecognized SSL message
  • cb1a54a: 8195809: [TESTBUG] jps and jcmd -l support for containers is not tested
  • 3330f9c: 8301170: perfMemory_windows.cpp add free_security_attr to early returns
  • 651ec7d: 8301760: Fix possible leak in SpNegoContext dispose

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 12, 2023
@openjdk openjdk bot closed this Feb 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 12, 2023
@openjdk
Copy link

openjdk bot commented Feb 12, 2023

@GoeLin Pushed as commit fab9770.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant