Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278241: Implement JVM SpinPause on linux-aarch64 #116

Closed
wants to merge 1 commit into from

Conversation

eastig
Copy link
Member

@eastig eastig commented Jan 24, 2022

A backport of a configurable implementation of JVM SpinPause to improve performance of contended locks and to achieve parity with x86 which has implemented SpinPause.
The risk of changes is low. They enable one ISB-based implementation for Neoverse N1. Other AArch64 will continue using an empty implementation.
Tested for fastdebug and release builds:

  • gtest: Passed
  • tier1...tier4: Passed
  • hotspot/jtreg/runtime/Thread/TestSpinPause.java: Passed

It can be considered as clean. Applying the patch has an issue to find a proper position in stubGenerator_aarch64.cpp. No code changes are needed after repositioning.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278241: Implement JVM SpinPause on linux-aarch64

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/116/head:pull/116
$ git checkout pull/116

Update a local copy of the PR:
$ git checkout pull/116
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/116/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 116

View PR using the GUI difftool:
$ git pr show -t 116

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/116.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2022

👋 Welcome back eastig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bcb79fd012c9c298e58c20c59e564e9d2c16b970 8278241: Implement JVM SpinPause on linux-aarch64 Jan 24, 2022
@openjdk
Copy link

openjdk bot commented Jan 24, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 24, 2022

@eastig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278241: Implement JVM SpinPause on linux-aarch64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • a93e5ef: 8275608: runtime/Metaspace/elastic/TestMetaspaceAllocationMT2 too slow
  • 096c31c: 8276057: Update JMH devkit to 1.33
  • 0cc9d30: 8275082: Update XML Security for Java to 2.3.0
  • 3d6f331: 8177814: jdk/editpad is not in jdk TEST.groups
  • 0a1419c: 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost"
  • 59d39ef: 8236505: Mark jdk/editpad/EditPadTest.java as @headful
  • 28dcaf3: 8272553: several hotspot runtime/CommandLine tests don't check exit code
  • 6315ce3: 8275687: runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException
  • 25a418d: 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 24, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2022

Webrevs

@eastig
Copy link
Member Author

eastig commented Jan 26, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 26, 2022
@openjdk
Copy link

openjdk bot commented Jan 26, 2022

@eastig
Your change (at version b75e37f) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 26, 2022

Going to push as commit 9378f26.
Since your change was applied there have been 9 commits pushed to the master branch:

  • a93e5ef: 8275608: runtime/Metaspace/elastic/TestMetaspaceAllocationMT2 too slow
  • 096c31c: 8276057: Update JMH devkit to 1.33
  • 0cc9d30: 8275082: Update XML Security for Java to 2.3.0
  • 3d6f331: 8177814: jdk/editpad is not in jdk TEST.groups
  • 0a1419c: 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost"
  • 59d39ef: 8236505: Mark jdk/editpad/EditPadTest.java as @headful
  • 28dcaf3: 8272553: several hotspot runtime/CommandLine tests don't check exit code
  • 6315ce3: 8275687: runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException
  • 25a418d: 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 26, 2022
@openjdk openjdk bot closed this Jan 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 26, 2022
@openjdk
Copy link

openjdk bot commented Jan 26, 2022

@phohensee @eastig Pushed as commit 9378f26.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants