New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278241: Implement JVM SpinPause on linux-aarch64 #116
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
@eastig This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change.
|
/integrate |
/sponsor |
Going to push as commit 9378f26.
Your commit was automatically rebased without conflicts. |
@phohensee @eastig Pushed as commit 9378f26. |
A backport of a configurable implementation of JVM SpinPause to improve performance of contended locks and to achieve parity with x86 which has implemented SpinPause.
The risk of changes is low. They enable one ISB-based implementation for Neoverse N1. Other AArch64 will continue using an empty implementation.
Tested for fastdebug and release builds:
gtest
: Passedtier1
...tier4
: Passedhotspot/jtreg/runtime/Thread/TestSpinPause.java
: PassedIt can be considered as clean. Applying the patch has an issue to find a proper position in
stubGenerator_aarch64.cpp
. No code changes are needed after repositioning.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/116/head:pull/116
$ git checkout pull/116
Update a local copy of the PR:
$ git checkout pull/116
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/116/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 116
View PR using the GUI difftool:
$ git pr show -t 116
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/116.diff