Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294958: java/net/httpclient/ConnectTimeout tests are slow #1167

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 13, 2023

I backport this for parity with 17.0.7-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294958: java/net/httpclient/ConnectTimeout tests are slow

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1167/head:pull/1167
$ git checkout pull/1167

Update a local copy of the PR:
$ git checkout pull/1167
$ git pull https://git.openjdk.org/jdk17u-dev pull/1167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1167

View PR using the GUI difftool:
$ git pr show -t 1167

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1167.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fe70487d0bc53149150c23d39287d9856c5a0e95 8294958: java/net/httpclient/ConnectTimeout tests are slow Feb 13, 2023
@openjdk
Copy link

openjdk bot commented Feb 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 13, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294958: java/net/httpclient/ConnectTimeout tests are slow

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 13, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Feb 15, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 15, 2023

Going to push as commit 0ce70e3.
Since your change was applied there have been 7 commits pushed to the master branch:

  • efe8676: 8279614: The left line of the TitledBorder is not painted on 150 scale factor
  • 036029e: 8281170: Test jdk/tools/jpackage/windows/WinInstallerIconTest always fails on Windows 11
  • 9e26f38: 8300266: Detect Virtualization on Linux aarch64
  • 68d7ac5: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines
  • 8b30968: 8300205: Swing test bug8078268 make latch timeout configurable
  • 17084d5: 8299957: Enhance error logging in instrument coding with additional jplis_assert_msg
  • 95a805b: 8299671: Speed up compiler/intrinsics/string/TestStringLatin1IndexOfChar.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 15, 2023
@openjdk openjdk bot closed this Feb 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 15, 2023
@openjdk
Copy link

openjdk bot commented Feb 15, 2023

@GoeLin Pushed as commit 0ce70e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant