8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption

[asgibbons]

This change boosts AES-CTR decrypt performance about 3x.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1169/head:pull/1169
$ git checkout pull/1169

Update a local copy of the PR:
$ git checkout pull/1169
$ git pull https://git.openjdk.org/jdk17u-dev pull/1169/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1169

View PR using the GUI difftool:
$ git pr show -t 1169

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1169.diff

[bridgekeeper]

👋 Welcome back sgibbons! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@asgibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 9bacd0c: 8266974: duplicate property key in java.sql.rowset resource bundle
• a5c97d4: 8300751: [17u] Remove duplicate entry in javac.properties
• c8ee076: 8245654: Add Certigna Root CA
• a0cda28: 8294902: Undefined Behavior in C2 regalloc with null references
• 3c1e03b: 8251177: [macosx] The text "big" is truncated in JTabbedPane
• bf4e659: 8272702: Resolving URI relative path with no / may lead to incorrect toString
• da62b2b: 8299970: Speed up compiler/arraycopy/TestArrayCopyConjoint.java
• fcd9110: 8298472: AArch64: Detect Ampere-1 and Ampere-1A CPUs and set default options
• a6f4cf1: 8302152: Speed up tests with infinite loops, sleep less
• 49ff97c: 8301342: Prefer ArrayList to LinkedList in LayoutComparator
• ... and 14 more: https://git.openjdk.org/jdk17u-dev/compare/a800231f17a5081de7f2336742faa97b11f12b3b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (4ce2b01b)

[GoeLin]

Could you please elaborato on risk and testing in your JBS comment? See https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix

[asgibbons]

I believe the risk is very low as it just restricts the amount of memory to be allocated. I've tested this with tier1.

[asgibbons]

@GoeLin Can I get an update on this please? Anything else I need to do?

[RealCLanger]

@GoeLin Can I get an update on this please? Anything else I need to do?

Hi @asgibbons,
I believe you should have restored the jdk17u-fix-request label to get Goetz' attention. However, I've checked your request and approved it. I think it's a reasonable performance improvement with acceptable risk.

[asgibbons]

Thanks, @RealCLanger .

/integrate

[openjdk]

@asgibbons
Your change (at version 4ce2b01) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit 9c35d59.
Since your change was applied there have been 25 commits pushed to the master branch:

• 53caaf5: 8289647: AssertionError during annotation processing of record related tests
• 9bacd0c: 8266974: duplicate property key in java.sql.rowset resource bundle
• a5c97d4: 8300751: [17u] Remove duplicate entry in javac.properties
• c8ee076: 8245654: Add Certigna Root CA
• a0cda28: 8294902: Undefined Behavior in C2 regalloc with null references
• 3c1e03b: 8251177: [macosx] The text "big" is truncated in JTabbedPane
• bf4e659: 8272702: Resolving URI relative path with no / may lead to incorrect toString
• da62b2b: 8299970: Speed up compiler/arraycopy/TestArrayCopyConjoint.java
• fcd9110: 8298472: AArch64: Detect Ampere-1 and Ampere-1A CPUs and set default options
• a6f4cf1: 8302152: Speed up tests with infinite loops, sleep less
• ... and 15 more: https://git.openjdk.org/jdk17u-dev/compare/a800231f17a5081de7f2336742faa97b11f12b3b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @asgibbons Pushed as commit 9c35d59.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.