New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption #1169
Conversation
👋 Welcome back sgibbons! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@asgibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
Could you please elaborato on risk and testing in your JBS comment? See https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix |
I believe the risk is very low as it just restricts the amount of memory to be allocated. I've tested this with tier1. |
@GoeLin Can I get an update on this please? Anything else I need to do? |
Hi @asgibbons, |
Thanks, @RealCLanger . /integrate |
@asgibbons |
/sponsor |
Going to push as commit 9c35d59.
Your commit was automatically rebased without conflicts. |
@RealCLanger @asgibbons Pushed as commit 9c35d59. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This change boosts AES-CTR decrypt performance about 3x.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1169/head:pull/1169
$ git checkout pull/1169
Update a local copy of the PR:
$ git checkout pull/1169
$ git pull https://git.openjdk.org/jdk17u-dev pull/1169/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1169
View PR using the GUI difftool:
$ git pr show -t 1169
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1169.diff