New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8301842: JFR: increase checkpoint event size for stacktrace and string pool #1173
Conversation
👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@kvergizova This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Have you tried to open .jfr files with earlier versions of JMC? I tried "jfr print" with JDK 11, and it still works for u4 sized events, but it would be good to confirm it also works with JMC 7 since it uses a different parser than the JDK. |
I successfully opened new .jfr files with JMC 7.0.0. So it still works for u4 sized events. |
/integrate |
Going to push as commit fb6d6fe.
Your commit was automatically rebased without conflicts. |
@kvergizova Pushed as commit fb6d6fe. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I'd like to backport JDK-8301842 as a small follow up fix for JDK-8298129 which is already included in 17u.
The patch applies cleanly.
Tested with tier1 and jdk/jfr.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1173/head:pull/1173
$ git checkout pull/1173
Update a local copy of the PR:
$ git checkout pull/1173
$ git pull https://git.openjdk.org/jdk17u-dev pull/1173/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1173
View PR using the GUI difftool:
$ git pr show -t 1173
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1173.diff