Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299970: Speed up compiler/arraycopy/TestArrayCopyConjoint.java #1178

Closed

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Feb 17, 2023

Backport for https://bugs.openjdk.org/browse/JDK-8299970

Clean backport, test update, low risk
Test passes


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299970: Speed up compiler/arraycopy/TestArrayCopyConjoint.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1178/head:pull/1178
$ git checkout pull/1178

Update a local copy of the PR:
$ git checkout pull/1178
$ git pull https://git.openjdk.org/jdk17u-dev pull/1178/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1178

View PR using the GUI difftool:
$ git pr show -t 1178

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1178.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2023

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5d39d14522df5dc35a5f4c9934d2cf8da4fecaa6 8299970: Speed up compiler/arraycopy/TestArrayCopyConjoint.java Feb 17, 2023
@openjdk
Copy link

openjdk bot commented Feb 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 17, 2023

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299970: Speed up compiler/arraycopy/TestArrayCopyConjoint.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5027f56: 8288332: Tier1 validate-source fails after 8279614
  • d0e0633: 8302692: [17u] Update GHA Boot JDK to 17.0.6

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 17, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 17, 2023

Webrevs

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 20, 2023
@openjdk
Copy link

openjdk bot commented Feb 20, 2023

@Rudometov
Your change (at version 0289525) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 21, 2023

Going to push as commit da62b2b.
Since your change was applied there have been 5 commits pushed to the master branch:

  • fcd9110: 8298472: AArch64: Detect Ampere-1 and Ampere-1A CPUs and set default options
  • a6f4cf1: 8302152: Speed up tests with infinite loops, sleep less
  • 49ff97c: 8301342: Prefer ArrayList to LinkedList in LayoutComparator
  • 5027f56: 8288332: Tier1 validate-source fails after 8279614
  • d0e0633: 8302692: [17u] Update GHA Boot JDK to 17.0.6

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 21, 2023
@openjdk openjdk bot closed this Feb 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 21, 2023
@openjdk
Copy link

openjdk bot commented Feb 21, 2023

@phohensee @Rudometov Pushed as commit da62b2b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants