Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299234: JMX Repository.query performance #1182

Closed
wants to merge 1 commit into from

Conversation

alexeybakhtin
Copy link

@alexeybakhtin alexeybakhtin commented Feb 21, 2023

Clean backport of JDK-8299234 to JDK17u

Performance of the original code:
JmxBenchmark.queryMBeansForMyObjectName 1000 thrpt 10 84.794 ± 0.784 ops/s
JmxBenchmark.queryMBeansForObjectName 1000 thrpt 10 145.286 ± 0.798 ops/s
JmxBenchmark.queryNamesForMyObjectName 1000 thrpt 10 80.715 ± 2.290 ops/s
JmxBenchmark.queryNamesForObjectName 1000 thrpt 10 147.780 ± 4.246 ops/s

Performance after patch applied:
JmxBenchmark.queryMBeansForMyObjectName 1000 thrpt 10 106.338 ± 4.865 ops/s
JmxBenchmark.queryMBeansForObjectName 1000 thrpt 10 216.965 ± 3.543 ops/s
JmxBenchmark.queryNamesForMyObjectName 1000 thrpt 10 102.794 ± 4.874 ops/s
JmxBenchmark.queryNamesForObjectName 1000 thrpt 10 236.722 ± 1.957 ops/s


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8299234 needs maintainer approval

Issue

  • JDK-8299234: JMX Repository.query performance (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1182/head:pull/1182
$ git checkout pull/1182

Update a local copy of the PR:
$ git checkout pull/1182
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1182/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1182

View PR using the GUI difftool:
$ git pr show -t 1182

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1182.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2023

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9a797228f3576720196d5e3bf4b204a5e3f87376 8299234: JMX Repository.query performance Feb 21, 2023
@openjdk
Copy link

openjdk bot commented Feb 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 21, 2023

@alexeybakhtin This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 21, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2023

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2023

@alexeybakhtin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 2, 2023
@alexeybakhtin
Copy link
Author

/open

@openjdk openjdk bot reopened this Aug 14, 2024
@openjdk
Copy link

openjdk bot commented Aug 14, 2024

@alexeybakhtin This pull request is now open

@openjdk
Copy link

openjdk bot commented Aug 14, 2024

⚠️ @alexeybakhtin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 14, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 11, 2024

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 9, 2024

@alexeybakhtin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant