-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8299234: JMX Repository.query performance #1182
Conversation
👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@alexeybakhtin This change is no longer ready for integration - check the PR body for details. |
@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@alexeybakhtin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
/open |
@alexeybakhtin This pull request is now open |
|
@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@alexeybakhtin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Clean backport of JDK-8299234 to JDK17u
Performance of the original code:
JmxBenchmark.queryMBeansForMyObjectName 1000 thrpt 10 84.794 ± 0.784 ops/s
JmxBenchmark.queryMBeansForObjectName 1000 thrpt 10 145.286 ± 0.798 ops/s
JmxBenchmark.queryNamesForMyObjectName 1000 thrpt 10 80.715 ± 2.290 ops/s
JmxBenchmark.queryNamesForObjectName 1000 thrpt 10 147.780 ± 4.246 ops/s
Performance after patch applied:
JmxBenchmark.queryMBeansForMyObjectName 1000 thrpt 10 106.338 ± 4.865 ops/s
JmxBenchmark.queryMBeansForObjectName 1000 thrpt 10 216.965 ± 3.543 ops/s
JmxBenchmark.queryNamesForMyObjectName 1000 thrpt 10 102.794 ± 4.874 ops/s
JmxBenchmark.queryNamesForObjectName 1000 thrpt 10 236.722 ± 1.957 ops/s
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1182/head:pull/1182
$ git checkout pull/1182
Update a local copy of the PR:
$ git checkout pull/1182
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1182/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1182
View PR using the GUI difftool:
$ git pr show -t 1182
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1182.diff
Webrev
Link to Webrev Comment