Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8302879: doc/building.md update link to jtreg builds #1183

Closed
wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Feb 21, 2023

The Eclipse Adoptium project recently moved its CI from ci.adoptopenjdk.net to ci.adoptium.net. The link to jtreg builds needs updating

Backport is clean (except for a differing format in the HTML version)

See adoptium/infrastructure#2932 for more context


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8302879: doc/building.md update link to jtreg builds

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1183/head:pull/1183
$ git checkout pull/1183

Update a local copy of the PR:
$ git checkout pull/1183
$ git pull https://git.openjdk.org/jdk17u-dev pull/1183/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1183

View PR using the GUI difftool:
$ git pr show -t 1183

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1183.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2023

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bb3dfd6adbb58871bc7238107ed254831b22d48b 8302879: doc/building.md update link to jtreg builds Feb 21, 2023
@openjdk
Copy link

openjdk bot commented Feb 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 21, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2023

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Feb 24, 2023

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302879: doc/building.md update link to jtreg builds

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • bf4e659: 8272702: Resolving URI relative path with no / may lead to incorrect toString
  • da62b2b: 8299970: Speed up compiler/arraycopy/TestArrayCopyConjoint.java
  • fcd9110: 8298472: AArch64: Detect Ampere-1 and Ampere-1A CPUs and set default options

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 24, 2023
@gdams
Copy link
Member Author

gdams commented Feb 27, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 27, 2023

Going to push as commit e618681.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 70ea0e6: 8293000: Review running times of jshell regression tests
  • 9c35d59: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption
  • 53caaf5: 8289647: AssertionError during annotation processing of record related tests
  • 9bacd0c: 8266974: duplicate property key in java.sql.rowset resource bundle
  • a5c97d4: 8300751: [17u] Remove duplicate entry in javac.properties
  • c8ee076: 8245654: Add Certigna Root CA
  • a0cda28: 8294902: Undefined Behavior in C2 regalloc with null references
  • 3c1e03b: 8251177: [macosx] The text "big" is truncated in JTabbedPane
  • bf4e659: 8272702: Resolving URI relative path with no / may lead to incorrect toString
  • da62b2b: 8299970: Speed up compiler/arraycopy/TestArrayCopyConjoint.java
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/a6f4cf1aaadb8c17f01822ce510e43c74005258e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 27, 2023
@openjdk openjdk bot closed this Feb 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 27, 2023
@openjdk
Copy link

openjdk bot commented Feb 27, 2023

@gdams Pushed as commit e618681.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the doc branch February 27, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants