Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 28, 2023

I backport this test fix for parity with 17.0.8-oracle to 17.0.7.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8210927: JDB tests do not update source path after doing a redefine class

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1190/head:pull/1190
$ git checkout pull/1190

Update a local copy of the PR:
$ git checkout pull/1190
$ git pull https://git.openjdk.org/jdk17u-dev pull/1190/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1190

View PR using the GUI difftool:
$ git pr show -t 1190

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1190.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 61ac53f6e5a149c6ec68a8df43106e72bfd1ebb2 8210927: JDB tests do not update source path after doing a redefine class Feb 28, 2023
@openjdk
Copy link

openjdk bot commented Feb 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 28, 2023
@openjdk
Copy link

openjdk bot commented Feb 28, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8210927: JDB tests do not update source path after doing a redefine class

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 28, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Mar 3, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 3, 2023

Going to push as commit 181a7bb.
Since your change was applied there have been 2 commits pushed to the master branch:

  • bf51354: 8048190: NoClassDefFoundError omits original ExceptionInInitializerError
  • 7b967bf: 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 3, 2023
@openjdk openjdk bot closed this Mar 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 3, 2023
@openjdk
Copy link

openjdk bot commented Mar 3, 2023

@GoeLin Pushed as commit 181a7bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant