Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284524: Create an automated test for JDK-4422362 #1192

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 28, 2023

I backport this test fix for parity with 17.0.8-oracle to 17.0.7.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284524: Create an automated test for JDK-4422362

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1192/head:pull/1192
$ git checkout pull/1192

Update a local copy of the PR:
$ git checkout pull/1192
$ git pull https://git.openjdk.org/jdk17u-dev pull/1192/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1192

View PR using the GUI difftool:
$ git pr show -t 1192

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1192.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b9de0a7556f7be2c6afc6bb41bfa0339b639ff88 8284524: Create an automated test for JDK-4422362 Feb 28, 2023
@openjdk
Copy link

openjdk bot commented Feb 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 28, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284524: Create an automated test for JDK-4422362

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 28, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Mar 2, 2023

Pre-submit failure: unrelated.
test report generation failed:
ash: ./.github/scripts/gen-test-results.sh: No such file or directory

@GoeLin
Copy link
Member Author

GoeLin commented Mar 3, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 3, 2023

Going to push as commit ca049ec.
Since your change was applied there have been 4 commits pushed to the master branch:

  • fd93a6a: 8284767: Create an automated test for JDK-4422535
  • 181a7bb: 8210927: JDB tests do not update source path after doing a redefine class
  • bf51354: 8048190: NoClassDefFoundError omits original ExceptionInInitializerError
  • 7b967bf: 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 3, 2023
@openjdk openjdk bot closed this Mar 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 3, 2023
@openjdk
Copy link

openjdk bot commented Mar 3, 2023

@GoeLin Pushed as commit ca049ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant