Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303433: Bump update version for OpenJDK: jdk-17.0.8 #1194

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 1, 2023

The required version bump for 17.0.8


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303433: Bump update version for OpenJDK: jdk-17.0.8

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1194/head:pull/1194
$ git checkout pull/1194

Update a local copy of the PR:
$ git checkout pull/1194
$ git pull https://git.openjdk.org/jdk17u-dev pull/1194/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1194

View PR using the GUI difftool:
$ git pr show -t 1194

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1194.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 1, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 7, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303433: Bump update version for OpenJDK: jdk-17.0.8

Reviewed-by: rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 9b054a1: 8289511: Improve test coverage for XPath Axes: child
  • ca049ec: 8284524: Create an automated test for JDK-4422362
  • fd93a6a: 8284767: Create an automated test for JDK-4422535
  • 181a7bb: 8210927: JDB tests do not update source path after doing a redefine class
  • bf51354: 8048190: NoClassDefFoundError omits original ExceptionInInitializerError
  • 7b967bf: 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 7, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Mar 7, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 7, 2023

Going to push as commit 1cad49b.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 9b054a1: 8289511: Improve test coverage for XPath Axes: child
  • ca049ec: 8284524: Create an automated test for JDK-4422362
  • fd93a6a: 8284767: Create an automated test for JDK-4422535
  • 181a7bb: 8210927: JDB tests do not update source path after doing a redefine class
  • bf51354: 8048190: NoClassDefFoundError omits original ExceptionInInitializerError
  • 7b967bf: 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 7, 2023
@openjdk openjdk bot closed this Mar 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 7, 2023
@openjdk
Copy link

openjdk bot commented Mar 7, 2023

@GoeLin Pushed as commit 1cad49b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_8303433_bump branch September 18, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants