Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id #1198

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Mar 6, 2023

Hi all,
This pull request contains a backport of commit cfb0a25a from the openjdk/jdk repository.
The commit being backported was authored by Naoto Sato on 6 Mar 2023 and was reviewed by Iris Clark, Jaikiran Pai, Roger Riggs and Lance Andersen.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1198/head:pull/1198
$ git checkout pull/1198

Update a local copy of the PR:
$ git checkout pull/1198
$ git pull https://git.openjdk.org/jdk17u-dev pull/1198/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1198

View PR using the GUI difftool:
$ git pr show -t 1198

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1198.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cfb0a25a4ee1a9cebd88c84fa622c46fe1c89bae 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id Mar 6, 2023
@openjdk
Copy link

openjdk bot commented Mar 6, 2023

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review March 8, 2023 10:33
@openjdk
Copy link

openjdk bot commented Mar 8, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 1cad49b: 8303433: Bump update version for OpenJDK: jdk-17.0.8

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 8, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Mar 13, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 13, 2023

Going to push as commit b087032.
Since your change was applied there have been 3 commits pushed to the master branch:

  • c118b0e: 8270859: Post JEP 411 refactoring: client libs with maximum covering > 10K
  • 1ad9e68: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures
  • 1cad49b: 8303433: Bump update version for OpenJDK: jdk-17.0.8

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 13, 2023
@openjdk openjdk bot closed this Mar 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 13, 2023
@openjdk
Copy link

openjdk bot commented Mar 13, 2023

@mrserb Pushed as commit b087032.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant