Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303809: Dispose context in SPNEGO NegotiatorImpl #1203

Closed
wants to merge 1 commit into from

Conversation

alexeybakhtin
Copy link

@alexeybakhtin alexeybakhtin commented Mar 15, 2023

Almost clean backport of JDK-8303809

NegotiatorImpl is merged manually because of no JDK-8282632 in 17u - difference in IOException initialization

sun/security/jgss sun/security/krb5 sun/net/www/protocol/http tests passed successfully


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303809: Dispose context in SPNEGO NegotiatorImpl

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1203/head:pull/1203
$ git checkout pull/1203

Update a local copy of the PR:
$ git checkout pull/1203
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1203/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1203

View PR using the GUI difftool:
$ git pr show -t 1203

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1203.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 15, 2023

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 10f16746254ce62031f40ffb0f49f22e81cbe631 8303809: Dispose context in SPNEGO NegotiatorImpl Mar 15, 2023
@openjdk
Copy link

openjdk bot commented Mar 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 15, 2023

@alexeybakhtin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303809: Dispose context in SPNEGO NegotiatorImpl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 47e4dba: 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling
  • ac655ba: 8304880: [PPC64] VerifyOops code in C1 doesn't work with ZGC
  • 0f72c30: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java
  • 1253eb4: 8291638: Keep-Alive timeout of 0 should close connection immediately
  • f53661b: 8282227: Locale information for nb is not working properly
  • 590256d: 8275721: Name of UTC timezone in a locale changes depending on previous code
  • 8bc5ad1: 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers
  • a71545b: 8291226: Create Test Cases to cover scenarios for JDK-8278067
  • ec7f169: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value
  • 59d8211: 8287541: Files.writeString fails to throw IOException for charset "windows-1252"
  • ... and 16 more: https://git.openjdk.org/jdk17u-dev/compare/4baaa110d6135adfb8e4c7ca9a0bef60ea93598c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 15, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2023

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@GoeLin
Copy link
Member

GoeLin commented May 23, 2023

What is wrong with the pre-submti tests?
Please only label fix-request after checking and sharing what was wrong!

@alexeybakhtin
Copy link
Author

alexeybakhtin commented May 23, 2023

What is wrong with the pre-submti tests? Please only label fix-request after checking and sharing what was wrong!

the pre-submit test fails on the linux/ppc64le build only and the failure is unrelated to the PR itself. infrastructure issue - linux/ppc64le build can not download sysroot file.

@alexeybakhtin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented May 26, 2023

Going to push as commit 1684377.
Since your change was applied there have been 205 commits pushed to the master branch:

  • 6919ff2: 8301119: Support for GB18030-2022
  • 3d32a20: 8286331: jni_GetStringUTFChars() uses wrong heap allocator
  • 6287df0: 8286346: 3-parameter version of AllocateHeap should not ignore AllocFailType
  • 6803da9: 8301661: Enhance os::pd_print_cpu_info on macOS and Windows
  • 0d2cc35: 8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses
  • 5bf1b9a: 8283520: JFR: Memory leak in dcmd_arena
  • c581886: 8307128: Open source some drag and drop tests 4
  • 14779b1: 8294717: (bf) DirectByteBuffer constructor will leak if allocating Deallocator or Cleaner fails with OOME
  • 57d0a7f: 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors
  • 436d96f: 8275287: Relax memory ordering constraints on updating instance class and array class counters
  • ... and 195 more: https://git.openjdk.org/jdk17u-dev/compare/4baaa110d6135adfb8e4c7ca9a0bef60ea93598c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 26, 2023
@openjdk openjdk bot closed this May 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 26, 2023
@openjdk
Copy link

openjdk bot commented May 26, 2023

@alexeybakhtin Pushed as commit 1684377.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants