8292301: [REDO v2] C2 crash when allocating array of size too large

[GoeLin]

I had to resolve three files:
src/hotspot/share/opto/callnode.cpp
AllocateArrayNode::Ideal could not be deleted automatically.
The patch removes igvn->add_input_to(phase->C->root(), halt);
but 11 has phase->C->root()->add_req(halt);
Just deleted anyways.

src/hotspot/share/opto/loopopts.cpp
In the source, clone_loop() has been refactored.
The patch touches code moved to finish_clone_loop().
The very same code is in clone_loop() in 17. Moved
hunk there.

src/hotspot/share/opto/phaseX.cpp
Just placement of a comment.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292301: [REDO v2] C2 crash when allocating array of size too large

Reviewers

• Roland Westrelin (@rwestrel - Reviewer)
• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1204/head:pull/1204
$ git checkout pull/1204

Update a local copy of the PR:
$ git checkout pull/1204
$ git pull https://git.openjdk.org/jdk17u-dev pull/1204/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1204

View PR using the GUI difftool:
$ git pr show -t 1204

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1204.diff

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[mlbridge]

Webrevs

• 00: Full (d250f3a6)

[jerboaa]

@rwestrel Hi! Could you please help review this? Thanks!

[rwestrel]

Looks good to me.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292301: [REDO v2] C2 crash when allocating array of size too large

Reviewed-by: roland, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• c005682: 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
• fba6dd8: 8301050: Detect Xen Virtualization on Linux aarch64
• c6805e6: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheRealMDoerr]

Thanks for the detailed description! Backport looks correct to me.

[GoeLin]

/integrate

[openjdk]

Going to push as commit cc170c7.
Since your change was applied there have been 5 commits pushed to the master branch:

• 15674a9: 8304063: tools/jpackage/share/AppLauncherEnvTest.java fails when checking LD_LIBRARY_PATH
• 752494f: 8303949: gcc10 warning Linux ppc64le - note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
• c005682: 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
• fba6dd8: 8301050: Detect Xen Virtualization on Linux aarch64
• c6805e6: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit cc170c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.