Skip to content

8257856: Make ClassFileVersionsTest.java robust to JDK version updates #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Mar 17, 2023

Backport JDK-8257856 for Oracle parity. Test update is not exactly needed in a backport release because no Java version update will occur there. However, it's good to have the same test code base in all releases.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8257856: Make ClassFileVersionsTest.java robust to JDK version updates

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1208/head:pull/1208
$ git checkout pull/1208

Update a local copy of the PR:
$ git checkout pull/1208
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1208

View PR using the GUI difftool:
$ git pr show -t 1208

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1208.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8b042d14b78c66b50495d0d8b559ca3f6744d806 8257856: Make ClassFileVersionsTest.java robust to JDK version updates Mar 17, 2023
@openjdk
Copy link

openjdk bot commented Mar 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 17, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 17, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 21, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257856: Make ClassFileVersionsTest.java robust to JDK version updates

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 47e4dba: 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling
  • ac655ba: 8304880: [PPC64] VerifyOops code in C1 doesn't work with ZGC
  • 0f72c30: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java
  • 1253eb4: 8291638: Keep-Alive timeout of 0 should close connection immediately
  • f53661b: 8282227: Locale information for nb is not working properly
  • 590256d: 8275721: Name of UTC timezone in a locale changes depending on previous code
  • 8bc5ad1: 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers
  • a71545b: 8291226: Create Test Cases to cover scenarios for JDK-8278067
  • ec7f169: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value
  • 59d8211: 8287541: Files.writeString fails to throw IOException for charset "windows-1252"
  • ... and 13 more: https://git.openjdk.org/jdk17u-dev/compare/c00568255be4fef9183ee9650775702efff43d43...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 21, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2023

@RealCLanger This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 4, 2023

Going to push as commit 79aa7b1.
Since your change was applied there have been 117 commits pushed to the master branch:

  • d8d69f3: 8303508: Vector.lane() gets wrong value on x86
  • 1d7b9ad: 8303069: Memory leak in CompilerOracle::parse_from_line
  • 820030a: 8303564: C2: "Bad graph detected in build_loop_late" after a CMove is wrongly split thru phi
  • 04eb720: 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling
  • 345e370: 8303861: Error handling step timeouts should never be blocked by OnError and others
  • 5ed9696: 8305481: gtest is_first_C_frame failing on ARM
  • 96adf07: 8297955: LDAP CertStore should use LdapName and not String for DNs
  • 65a02da: 8303476: Add the runtime version in the release file of a JDK image
  • 07993bf: 8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies
  • 5296357: 8303822: gtestMain should give more helpful output
  • ... and 107 more: https://git.openjdk.org/jdk17u-dev/compare/c00568255be4fef9183ee9650775702efff43d43...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 4, 2023
@openjdk openjdk bot closed this May 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

@RealCLanger Pushed as commit 79aa7b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-8b042d14 branch May 4, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants