Skip to content

8302849: SurfaceManager might expose partially constructed object #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Mar 24, 2023

Hi all,
This pull request contains a backport of commit 63ef2143 from the openjdk/jdk repository.
The commit being backported was authored by Per Minborg on 22 Feb 2023 and was reviewed by Sergey Bylokhov.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8302849: SurfaceManager might expose partially constructed object

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1215/head:pull/1215
$ git checkout pull/1215

Update a local copy of the PR:
$ git checkout pull/1215
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1215/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1215

View PR using the GUI difftool:
$ git pr show -t 1215

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1215.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 63ef2143289f4aac52c8b2a6b555ed2b33dc1c07 8302849: SurfaceManager might expose partially constructed object Mar 24, 2023
@openjdk
Copy link

openjdk bot commented Mar 24, 2023

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review March 27, 2023 00:05
@openjdk
Copy link

openjdk bot commented Mar 27, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302849: SurfaceManager might expose partially constructed object

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 637155e: 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN
  • 6d61fc1: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 27, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 27, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Mar 27, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 27, 2023

Going to push as commit c6a35f5.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 637155e: 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN
  • 6d61fc1: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 27, 2023
@openjdk openjdk bot closed this Mar 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 27, 2023
@openjdk
Copy link

openjdk bot commented Mar 27, 2023

@mrserb Pushed as commit c6a35f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant