8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers

[MBaesken]

backport of 8304671

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1216/head:pull/1216
$ git checkout pull/1216

Update a local copy of the PR:
$ git checkout pull/1216
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1216/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1216

View PR using the GUI difftool:
$ git pr show -t 1216

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1216.diff

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[MBaesken]

src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java
copyright needs to be adjusted

test/langtools/tools/javac/parser/JavacParserTest.java
bug info comment does not fit in, needs to be manually adjusted

+                         - compiler.warn.option.obsolete.source: 8
+                         - compiler.warn.option.obsolete.target: 8
+                         - compiler.warn.option.obsolete.suppression

those warnings do not show up when compiling with jdk17 javac so they need to be removed from the Test setup

[mlbridge]

Webrevs

• 00: Full (fcad3a81)

[phohensee]

Clean except for JavacParser.java copyright date and JavacParserTest.java bug list.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• c6a35f5: 8302849: SurfaceManager might expose partially constructed object
• 637155e: 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN
• 6d61fc1: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[MBaesken]

/integrate

[openjdk]

Going to push as commit 8bc5ad1.
Since your change was applied there have been 10 commits pushed to the master branch:

• a71545b: 8291226: Create Test Cases to cover scenarios for JDK-8278067
• ec7f169: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value
• 59d8211: 8287541: Files.writeString fails to throw IOException for charset "windows-1252"
• 6ba50fc: 8286287: Reading file as UTF-16 causes Error which "shouldn't happen"
• 7cf28d5: 8283062: Uninitialized warnings in libgtest with GCC 11.2
• 268a6a5: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error
• ac0b7c9: 8268288: jdk/jfr/api/consumer/streaming/TestOutOfProcessMigration.java fails with "Error: ShouldNotReachHere()"
• c6a35f5: 8302849: SurfaceManager might expose partially constructed object
• 637155e: 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN
• 6d61fc1: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 8bc5ad1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.