Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280155: [PPC64, s390] frame size checks are not yet correct #123

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jan 26, 2022

Clean Backport of JDK-8279924.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280155: [PPC64, s390] frame size checks are not yet correct

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/123/head:pull/123
$ git checkout pull/123

Update a local copy of the PR:
$ git checkout pull/123
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/123/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 123

View PR using the GUI difftool:
$ git pr show -t 123

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/123.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into pr/122 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f37bfeadcf036a75defc64ad7f4a9f5596cd7407 8280155: [PPC64, s390] frame size checks are not yet correct Jan 26, 2022
@openjdk
Copy link

openjdk bot commented Jan 26, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr labels Jan 26, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2022

Webrevs

@TheRealMDoerr TheRealMDoerr changed the base branch from pr/122 to master Jan 31, 2022
@openjdk openjdk bot removed the clean label Jan 31, 2022
@TheRealMDoerr TheRealMDoerr force-pushed the 8280155_ppc64_s390_frame_checks branch from bf1fa58 to 383908b Compare Jan 31, 2022
@openjdk openjdk bot added the clean label Jan 31, 2022
@openjdk
Copy link

openjdk bot commented Jan 31, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280155: [PPC64, s390] frame size checks are not yet correct

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 31, 2022
@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Jan 31, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 31, 2022

Going to push as commit ac8a550.

@openjdk openjdk bot added the integrated label Jan 31, 2022
@openjdk openjdk bot closed this Jan 31, 2022
@TheRealMDoerr TheRealMDoerr deleted the 8280155_ppc64_s390_frame_checks branch Jan 31, 2022
@openjdk openjdk bot removed ready rfr labels Jan 31, 2022
@openjdk
Copy link

openjdk bot commented Jan 31, 2022

@TheRealMDoerr Pushed as commit ac8a550.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant