Skip to content

8288589: Files.readString ignores encoding errors for UTF-16 #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 29, 2023

I backport this for parity with 17.0.8-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288589: Files.readString ignores encoding errors for UTF-16

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1230/head:pull/1230
$ git checkout pull/1230

Update a local copy of the PR:
$ git checkout pull/1230
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1230/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1230

View PR using the GUI difftool:
$ git pr show -t 1230

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1230.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2728770e3d73bb11c4d6e54b5aff91588a1a780b 8288589: Files.readString ignores encoding errors for UTF-16 Mar 29, 2023
@openjdk
Copy link

openjdk bot commented Mar 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 29, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288589: Files.readString ignores encoding errors for UTF-16

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 47e4dba: 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling
  • ac655ba: 8304880: [PPC64] VerifyOops code in C1 doesn't work with ZGC
  • 0f72c30: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java
  • 1253eb4: 8291638: Keep-Alive timeout of 0 should close connection immediately
  • f53661b: 8282227: Locale information for nb is not working properly
  • 590256d: 8275721: Name of UTC timezone in a locale changes depending on previous code
  • 8bc5ad1: 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 29, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Apr 16, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Apr 16, 2023

Going to push as commit acbac0d.
Since your change was applied there have been 15 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 16, 2023
@openjdk openjdk bot closed this Apr 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 16, 2023
@openjdk
Copy link

openjdk bot commented Apr 16, 2023

@GoeLin Pushed as commit acbac0d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant