Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c #1231

Closed
wants to merge 1 commit into from

Conversation

lutkerd
Copy link
Contributor

@lutkerd lutkerd commented Mar 30, 2023

Trivial backport to support building GCC 12 on Aarch64.

Successfully build on Linux x64 and aarc64 with gcc 12.2.0.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1231/head:pull/1231
$ git checkout pull/1231

Update a local copy of the PR:
$ git checkout pull/1231
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1231/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1231

View PR using the GUI difftool:
$ git pr show -t 1231

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1231.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 30, 2023

👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 02ea338177df781912dc782e32200eaf4731a0da 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c Mar 30, 2023
@openjdk
Copy link

openjdk bot commented Mar 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot removed the clean label Mar 31, 2023
@lutkerd lutkerd marked this pull request as ready for review March 31, 2023 19:02
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 31, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 31, 2023

Webrevs

@theRealAph
Copy link

Ouch. Do we really want to turn off that warning for all of the files in the library?

@lutkerd
Copy link
Contributor Author

lutkerd commented Mar 31, 2023

I'd be happy to backport openjdk/jdk@e45f3d5 and then we can cleanly disable warnings per file.

@openjdk
Copy link

openjdk bot commented Mar 31, 2023

@lutkerd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@lutkerd lutkerd closed this Mar 31, 2023
@lutkerd lutkerd reopened this Mar 31, 2023
@lutkerd lutkerd changed the base branch from master to pr/1232 March 31, 2023 21:31
@lutkerd
Copy link
Contributor Author

lutkerd commented Mar 31, 2023

/clean

@openjdk openjdk bot added the clean label Mar 31, 2023
@openjdk
Copy link

openjdk bot commented Mar 31, 2023

@lutkerd Only OpenJDK Committers can use the /clean command

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1232 to master April 4, 2023 18:47
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8293887
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@lutkerd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@lutkerd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean label Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 4, 2023
@lutkerd
Copy link
Contributor Author

lutkerd commented Apr 4, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@lutkerd
Your change (at version 47157e4) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 4, 2023

Going to push as commit 768bed2.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2023
@openjdk openjdk bot closed this Apr 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@phohensee @lutkerd Pushed as commit 768bed2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants