-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c #1231
Conversation
👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
Ouch. Do we really want to turn off that warning for all of the files in the library? |
I'd be happy to backport openjdk/jdk@e45f3d5 and then we can cleanly disable warnings per file. |
@lutkerd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
/clean |
@lutkerd Only OpenJDK Committers can use the |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8293887
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@lutkerd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
@lutkerd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
@lutkerd This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit 768bed2. |
@phohensee @lutkerd Pushed as commit 768bed2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Trivial backport to support building GCC 12 on Aarch64.
Successfully build on Linux x64 and aarc64 with gcc 12.2.0.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1231/head:pull/1231
$ git checkout pull/1231
Update a local copy of the PR:
$ git checkout pull/1231
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1231/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1231
View PR using the GUI difftool:
$ git pr show -t 1231
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1231.diff
Webrev
Link to Webrev Comment