Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294281: Allow warnings to be disabled on a per-file basis #1232

Closed
wants to merge 1 commit into from

Conversation

lutkerd
Copy link
Contributor

@lutkerd lutkerd commented Mar 31, 2023

Required by #1231


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294281: Allow warnings to be disabled on a per-file basis

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1232/head:pull/1232
$ git checkout pull/1232

Update a local copy of the PR:
$ git checkout pull/1232
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1232/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1232

View PR using the GUI difftool:
$ git pr show -t 1232

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1232.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2023

👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e45f3d5176e4affaa08480b560ca983fdbcb2846 8294281: Allow warnings to be disabled on a per-file basis Mar 31, 2023
@openjdk
Copy link

openjdk bot commented Mar 31, 2023

This backport pull request has now been updated with issue from the original commit.

@lutkerd lutkerd marked this pull request as ready for review March 31, 2023 21:25
@openjdk
Copy link

openjdk bot commented Mar 31, 2023

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294281: Allow warnings to be disabled on a per-file basis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 47e4dba: 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling
  • ac655ba: 8304880: [PPC64] VerifyOops code in C1 doesn't work with ZGC
  • 0f72c30: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java
  • 1253eb4: 8291638: Keep-Alive timeout of 0 should close connection immediately
  • f53661b: 8282227: Locale information for nb is not working properly
  • 590256d: 8275721: Name of UTC timezone in a locale changes depending on previous code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 31, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 31, 2023

Webrevs

@lutkerd
Copy link
Contributor Author

lutkerd commented Apr 4, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@lutkerd
Your change (at version f86c060) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Apr 4, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 4, 2023

Going to push as commit 4c3aecb.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 47e4dba: 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling
  • ac655ba: 8304880: [PPC64] VerifyOops code in C1 doesn't work with ZGC
  • 0f72c30: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java
  • 1253eb4: 8291638: Keep-Alive timeout of 0 should close connection immediately
  • f53661b: 8282227: Locale information for nb is not working properly
  • 590256d: 8275721: Name of UTC timezone in a locale changes depending on previous code

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2023
@openjdk openjdk bot closed this Apr 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@mrserb @lutkerd Pushed as commit 4c3aecb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lutkerd lutkerd deleted the 8294281 branch April 4, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants