Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298887: On the latest macOS+XCode the Robot API may report wrong colors #1233

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Apr 4, 2023

Hi all,
This pull request contains a backport of commit 50120396 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 22 Dec 2022 and was reviewed by Alexander Zvegintsev.
Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298887: On the latest macOS+XCode the Robot API may report wrong colors

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1233/head:pull/1233
$ git checkout pull/1233

Update a local copy of the PR:
$ git checkout pull/1233
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1233/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1233

View PR using the GUI difftool:
$ git pr show -t 1233

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1233.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 50120396b6cca1219fb5dd42a11e4b29b79bd3bd 8298887: On the latest macOS+XCode the Robot API may report wrong colors Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 4, 2023
@mrserb mrserb marked this pull request as ready for review April 13, 2023 08:53
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 13, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 13, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only non-clean change I can see is that WindowAlphaCompositeTest.java does not exist in 17u. Lgtm.

@openjdk
Copy link

openjdk bot commented Apr 13, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298887: On the latest macOS+XCode the Robot API may report wrong colors

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • aeb7cf5: 8274864: Remove Amman/Cairo hacks in ZoneInfoFile
  • ce12880: 8302491: NoClassDefFoundError omits the original cause of an error
  • a296937: Merge
  • 908cab4: 8304871: Use default visibility for static library builds
  • 768bed2: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c
  • 4c3aecb: 8294281: Allow warnings to be disabled on a per-file basis

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 13, 2023
@mrserb
Copy link
Member Author

mrserb commented Apr 19, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Apr 19, 2023

Going to push as commit 6254bdf.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 02efaf7: 8269821: Remove is-queue-active check in inner loop of write_ref_array_pre_work
  • e6c2792: 8299959: C2: CmpU::Value must filter overflow computation against local sub computation
  • ff675cc: 8297000: [jib] Add more friendly warning for proxy issues
  • 9eeb741: 8295564: Norwegian Nynorsk Locale is missing formatting
  • e91b87e: 8294906: Memory leak in PKCS11 NSS TLS server
  • b0e142e: 8292755: Non-default method in interface leads to a stack overflow in JShell
  • 3aa85f9: 8287007: [cgroups] Consistently use stringStream throughout parsing code
  • fc03710: 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider
  • 2bf9828: 8245877: assert(_value != __null) failed: resolving NULL _value in JvmtiExport::post_compiled_method_load
  • f8408c7: 8305113: (tz) Update Timezone Data to 2023c
  • ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/47e4dba6a266caa7a3d6305113d903e657a6fb25...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 19, 2023
@openjdk openjdk bot closed this Apr 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 19, 2023
@openjdk
Copy link

openjdk bot commented Apr 19, 2023

@mrserb Pushed as commit 6254bdf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants