Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297000: [jib] Add more friendly warning for proxy issues #1249

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 17, 2023

I backport this for parity with 17.0.8-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297000: [jib] Add more friendly warning for proxy issues

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1249/head:pull/1249
$ git checkout pull/1249

Update a local copy of the PR:
$ git checkout pull/1249
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1249/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1249

View PR using the GUI difftool:
$ git pr show -t 1249

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1249.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0d93ab9dff04409469faa26d5cdb29c4d6488537 8297000: [jib] Add more friendly warning for proxy issues Apr 17, 2023
@openjdk
Copy link

openjdk bot commented Apr 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 17, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297000: [jib] Add more friendly warning for proxy issues

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • f8408c7: 8305113: (tz) Update Timezone Data to 2023c

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 17, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Apr 18, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Apr 18, 2023

Going to push as commit ff675cc.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 9eeb741: 8295564: Norwegian Nynorsk Locale is missing formatting
  • e91b87e: 8294906: Memory leak in PKCS11 NSS TLS server
  • b0e142e: 8292755: Non-default method in interface leads to a stack overflow in JShell
  • 3aa85f9: 8287007: [cgroups] Consistently use stringStream throughout parsing code
  • fc03710: 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider
  • 2bf9828: 8245877: assert(_value != __null) failed: resolving NULL _value in JvmtiExport::post_compiled_method_load
  • f8408c7: 8305113: (tz) Update Timezone Data to 2023c

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 18, 2023
@openjdk openjdk bot closed this Apr 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 18, 2023
@openjdk
Copy link

openjdk bot commented Apr 18, 2023

@GoeLin Pushed as commit ff675cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant