Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278604: SwingSet2 table demo does not have accessible description set for images #125

Closed

Conversation

savoptik
Copy link
Contributor

@savoptik savoptik commented Jan 27, 2022

Hi all,

This pull request contains a backport of commit 8fbe1724 from the openjdk/jdk repository.

The commit being backported was authored by Artem Semenov on 17 Dec 2021 and was reviewed by Anton Tarasov, Alexander Zuev and Pankaj Bansal.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8278604: SwingSet2 table demo does not have accessible description set for images
  • JDK-8278526: [macos] Screen reader reads SwingSet2 JTable row selection as null, dimmed row for last column

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/125/head:pull/125
$ git checkout pull/125

Update a local copy of the PR:
$ git checkout pull/125
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/125/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 125

View PR using the GUI difftool:
$ git pr show -t 125

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/125.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 27, 2022

👋 Welcome back asemenov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8fbe1724e0f783132a65c45503addad9d98a329e 8278604: SwingSet2 table demo does not have accessible description set for images Jan 27, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 27, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 27, 2022

@savoptik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278604: SwingSet2 table demo does not have accessible description set for images
8278526: [macos] Screen reader reads SwingSet2 JTable row selection as null, dimmed row for last column

Reviewed-by: ant, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 7a5a8ab: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}
  • d34650a: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0
  • 3bd7875: 8279445: Update JMH devkit to 1.34
  • b23271b: 8274753: ZGC: SEGV in MetaspaceShared::link_shared_classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@forantar, @azuev-java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Jan 27, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 27, 2022

Webrevs

@savoptik
Copy link
Contributor Author

@savoptik savoptik commented Jan 31, 2022

/integrate

@openjdk openjdk bot added the sponsor label Jan 31, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 31, 2022

@savoptik
Your change (at version 5011821) is now ready to be sponsored by a Committer.

@forantar
Copy link

@forantar forantar commented Feb 1, 2022

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2022

Going to push as commit 592adc8.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 952f9c7: 8275645: [JVMCI] avoid unaligned volatile reads on AArch64
  • 869bb36: 8280414: Memory leak in DefaultProxySelector
  • c581598: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
  • cb769c0: 8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error
  • ac8a550: 8280155: [PPC64, s390] frame size checks are not yet correct
  • 22a6279: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks
  • 7a5a8ab: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}
  • d34650a: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0
  • 3bd7875: 8279445: Update JMH devkit to 1.34
  • b23271b: 8274753: ZGC: SEGV in MetaspaceShared::link_shared_classes

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 1, 2022
@openjdk openjdk bot closed this Feb 1, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Feb 1, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2022

@forantar @savoptik Pushed as commit 592adc8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
3 participants