Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8201516: DebugNonSafepoints generates incorrect information #1255

Closed

Conversation

apangin
Copy link

@apangin apangin commented Apr 17, 2023

Hi all,

This pull request contains a backport of commit 94eda53d from the openjdk/jdk repository.

The commit being backported was authored by Tobias Hartmann on 7 Mar 2023 and was reviewed by Vladimir Kozlov and Roland Westrelin.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8201516: DebugNonSafepoints generates incorrect information

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1255/head:pull/1255
$ git checkout pull/1255

Update a local copy of the PR:
$ git checkout pull/1255
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1255/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1255

View PR using the GUI difftool:
$ git pr show -t 1255

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1255.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2023

👋 Welcome back apangin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 94eda53d98e5011cc613d031ff8941e254eb666b 8201516: DebugNonSafepoints generates incorrect information Apr 17, 2023
@openjdk
Copy link

openjdk bot commented Apr 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 17, 2023

@apangin This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 17, 2023

Webrevs

@apangin apangin marked this pull request as draft April 18, 2023 01:53
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 18, 2023
@GoeLin
Copy link
Member

GoeLin commented Apr 18, 2023

Hi @apangin

please check the test results before labeling fix-request.
Also, the PR is not ready. You should only label if all is done. See also https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix

@apangin apangin closed this Apr 19, 2023
@apangin
Copy link
Author

apangin commented Apr 19, 2023

This PR is obsoleted by #1268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants