-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8277180: Intrinsify recursive ObjectMonitor locking for C2 x64 and A64 #126
Conversation
👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@dchuyko This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 149 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit dba064a.
Your commit was automatically rebased without conflicts. |
@phohensee @dchuyko Pushed as commit dba064a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This change for 2 ISAs fixes the performance regression seen between 11 and 17. Numbers in the issue (x86 I guess) mention 17% in Dacapo h2. AArch64 results for 17u in that benchmark are slightly different but still impressive: 17u now is ~3% worse than 11u, this patch improves the score by 10%.
Original patch applies cleanly.
Testing: jtreg tier1, tier2 in dev environment, pre-submit checks.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/126/head:pull/126
$ git checkout pull/126
Update a local copy of the PR:
$ git checkout pull/126
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/126/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 126
View PR using the GUI difftool:
$ git pr show -t 126
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/126.diff