Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277180: Intrinsify recursive ObjectMonitor locking for C2 x64 and A64 #126

Closed
wants to merge 1 commit into from

Conversation

dchuyko
Copy link
Member

@dchuyko dchuyko commented Jan 27, 2022

This change for 2 ISAs fixes the performance regression seen between 11 and 17. Numbers in the issue (x86 I guess) mention 17% in Dacapo h2. AArch64 results for 17u in that benchmark are slightly different but still impressive: 17u now is ~3% worse than 11u, this patch improves the score by 10%.

Original patch applies cleanly.

Testing: jtreg tier1, tier2 in dev environment, pre-submit checks.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277180: Intrinsify recursive ObjectMonitor locking for C2 x64 and A64

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/126/head:pull/126
$ git checkout pull/126

Update a local copy of the PR:
$ git checkout pull/126
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/126/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 126

View PR using the GUI difftool:
$ git pr show -t 126

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/126.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2022

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d93b238f9725727ae1e2e9f203943b5ddf778f35 8277180: Intrinsify recursive ObjectMonitor locking for C2 x64 and A64 Jan 27, 2022
@openjdk
Copy link

openjdk bot commented Jan 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 27, 2022

@dchuyko This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277180: Intrinsify recursive ObjectMonitor locking for C2 x64 and A64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 149 new commits pushed to the master branch:

  • 952f9c7: 8275645: [JVMCI] avoid unaligned volatile reads on AArch64
  • 869bb36: 8280414: Memory leak in DefaultProxySelector
  • c581598: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
  • cb769c0: 8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error
  • ac8a550: 8280155: [PPC64, s390] frame size checks are not yet correct
  • 22a6279: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks
  • 7a5a8ab: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}
  • d34650a: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0
  • 3bd7875: 8279445: Update JMH devkit to 1.34
  • b23271b: 8274753: ZGC: SEGV in MetaspaceShared::link_shared_classes
  • ... and 139 more: https://git.openjdk.java.net/jdk17u-dev/compare/dcd98215f257f4e373dd58e0daf0013be2c53850...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2022

Webrevs

@dchuyko
Copy link
Member Author

dchuyko commented Feb 1, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 1, 2022
@openjdk
Copy link

openjdk bot commented Feb 1, 2022

@dchuyko
Your change (at version 6d65086) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 3, 2022

Going to push as commit dba064a.
Since your change was applied there have been 160 commits pushed to the master branch:

  • cd73095: 8277449: compiler/vectorapi/TestLongVectorNeg.java fails with release VMs
  • f723588: 8275643: C2's unaryOp vector intrinsic does not properly handle LongVector.neg
  • 27cbe24: 8271056: C2: "assert(no_dead_loop) failed: dead loop detected" due to cmoving identity
  • ff3eec1: 8275847: Scheduling fails with "too many D-U pinch points" on small method
  • 5d54bf5: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info
  • e459c8c: 8275874: [JVMCI] only support aligned reads in c2v_readFieldValue
  • 0b51fe2: 8271506: Add ResourceHashtable support for deleting selected entries
  • 6cacf9a: 8278381: [GCC 11] Address::make_raw() does not initialize rspec
  • c03b95d: 8279124: VM does not handle SIGQUIT during initialization
  • 45002c0: 8277497: Last column cell in the JTable row is read as empty cell
  • ... and 150 more: https://git.openjdk.java.net/jdk17u-dev/compare/dcd98215f257f4e373dd58e0daf0013be2c53850...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 3, 2022
@openjdk openjdk bot closed this Feb 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 3, 2022
@openjdk
Copy link

openjdk bot commented Feb 3, 2022

@phohensee @dchuyko Pushed as commit dba064a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants