8201516: DebugNonSafepoints generates incorrect information

[apangin]

Hi,

This is a backport of JDK-8201516: DebugNonSafepoints generates incorrect information

Original patch applies cleanly, except that for the jtreg test where I removed unsupported phase = CompilePhase.BEFORE_MATCHING. I verified that the test passes with the patch but fails without.

Testing: x86_64 build, tier1

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8201516: DebugNonSafepoints generates incorrect information

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1268/head:pull/1268
$ git checkout pull/1268

Update a local copy of the PR:
$ git checkout pull/1268
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1268/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1268

View PR using the GUI difftool:
$ git pr show -t 1268

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1268.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back apangin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[apangin]

/label hotspot-compiler

[mlbridge]

Webrevs

• 01: Full - Incremental (b57ec393)
• 00: Full (4ea31720)

[openjdk]

@apangin
The label hotspot-compiler is not a valid label.
These labels are valid:

[openjdk]

@apangin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[TobiHartmann]

Looks good to me.

[openjdk]

@apangin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8201516: DebugNonSafepoints generates incorrect information

Reviewed-by: thartmann, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• c43c0a4: Merge
• 22cdf79: 8299597: [17u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 17.0.7
• 12d2d0e: 8299129: Enhance NameService lookups
• e78fe92: 8298667: Improved path handling
• 0e67976: 8298310: Enhance TLS session negotiation
• dfded6d: 8298191: Enhance object reclamation process
• 13b5fe6: 8297371: Improve UTF8 representation redux
• 0c49bb7: 8296832: Improve Swing platform support
• ae88233: 8296692: Improve String platform support
• 43dd5ff: 8296684: Improve String platform support
• ... and 30 more: https://git.openjdk.org/jdk17u-dev/compare/e6c27925d23fe283a23c6adbe263658909c3739d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[apangin]

/integrate

[openjdk]

@apangin
Your change (at version b57ec39) is now ready to be sponsored by a Committer.

[shipilev]

The push approval is there.

/sponsor

[openjdk]

Going to push as commit 9d6f1d7.
Since your change was applied there have been 40 commits pushed to the master branch:

• c43c0a4: Merge
• 22cdf79: 8299597: [17u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 17.0.7
• 12d2d0e: 8299129: Enhance NameService lookups
• e78fe92: 8298667: Improved path handling
• 0e67976: 8298310: Enhance TLS session negotiation
• dfded6d: 8298191: Enhance object reclamation process
• 13b5fe6: 8297371: Improve UTF8 representation redux
• 0c49bb7: 8296832: Improve Swing platform support
• ae88233: 8296692: Improve String platform support
• 43dd5ff: 8296684: Improve String platform support
• ... and 30 more: https://git.openjdk.org/jdk17u-dev/compare/e6c27925d23fe283a23c6adbe263658909c3739d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @apangin Pushed as commit 9d6f1d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.