-
Notifications
You must be signed in to change notification settings - Fork 224
8296545: C2 Blackholes should allow load optimizations #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
What is wrong with the Pre-submit tests? |
Missing ebde2fb, apparently. Remerged from master. |
There was a little conflict in |
@TheRealMDoerr, @GoeLin, if you can ack again, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still good.
Thank you! Testing is still good. GHAs are green. Push approval is there. /integrate |
Unclean backport to improve Blackhole performance and match it to released JDK 20.
The backport is unclean because there are two little conflicts:
MemBarNode::make
, where theMemBarStoreStore
was moved to another place. I resolved the conflict by hand: accepted only theBlackhole
case removal.MUL_I
constant for test to work.Additional testing:
compiler/irTests/blackhole
(includes new test)Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1273/head:pull/1273
$ git checkout pull/1273
Update a local copy of the PR:
$ git checkout pull/1273
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1273/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1273
View PR using the GUI difftool:
$ git pr show -t 1273
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1273.diff
Webrev
Link to Webrev Comment