Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel #1281

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 19, 2023

I backport this for parity with 17.0.8-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1281/head:pull/1281
$ git checkout pull/1281

Update a local copy of the PR:
$ git checkout pull/1281
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1281/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1281

View PR using the GUI difftool:
$ git pr show -t 1281

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1281.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 19, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 79c0092125ef01e2980f8072d7b295ce0c1a6077 8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel Apr 19, 2023
@openjdk
Copy link

openjdk bot commented Apr 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 19, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 19, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 19, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Apr 20, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Apr 20, 2023

Going to push as commit ccc0690.
Since your change was applied there have been 9 commits pushed to the master branch:

  • fc9c2de: 8289949: Improve test coverage for XPath: operators
  • c2b379f: 8277775: Fixup bugids in RemoveDropTargetCrashTest.java - add 4357905
  • 37c5061: 8282704: runtime/Thread/StopAtExit.java may leak memory
  • 40b1daf: 8273909: vmTestbase/nsk/jdi/Event/request/request001 can still fail with "ERROR: new event is not ThreadStartEvent"
  • db3b06f: 8270434: JDI+UT: Unexpected event in JDI tests
  • ef1a9ec: 8270869: G1ServiceThread may not terminate
  • 52a66f9: 8268298: jdk/jfr/api/consumer/log/TestVerbosity.java fails: unexpected log message
  • 6254bdf: 8298887: On the latest macOS+XCode the Robot API may report wrong colors
  • 02efaf7: 8269821: Remove is-queue-active check in inner loop of write_ref_array_pre_work

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 20, 2023
@openjdk openjdk bot closed this Apr 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 20, 2023
@openjdk
Copy link

openjdk bot commented Apr 20, 2023

@GoeLin Pushed as commit ccc0690.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant