Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252990: Intrinsify Unsafe.storeStoreFence #1290

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 20, 2023

Clean backport to improve non-x86 platforms performance.

Additional testing:

  • Linux x86_64 fastdebug tier1
  • Linux x86_64 fastdebug tier2
  • Linux x86_64 fastdebug tier3
  • Linux AArch64 fastdebug tier1
  • Linux AArch64 fastdebug tier2
  • Linux AArch64 fastdebug tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1290/head:pull/1290
$ git checkout pull/1290

Update a local copy of the PR:
$ git checkout pull/1290
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1290/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1290

View PR using the GUI difftool:
$ git pr show -t 1290

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1290.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 20, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b7a06be98d3057dac4adbb7f4071ac62cf88fe52 8252990: Intrinsify Unsafe.storeStoreFence Apr 20, 2023
@openjdk
Copy link

openjdk bot commented Apr 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 20, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252990: Intrinsify Unsafe.storeStoreFence

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 20, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 20, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Apr 24, 2023

What is wrong with the Pre-submit tests?

I'll run it through SAP nightly testing.

@shipilev
Copy link
Member Author

What is wrong with the Pre-submit tests?
I'll run it through SAP nightly testing.

Missing ebde2fb, apparently. I merged from master, let's see if that helps.

@shipilev
Copy link
Member Author

What is wrong with the Pre-submit tests?
I'll run it through SAP nightly testing.

Missing ebde2fb, apparently. I merged from master, let's see if that helps.

Yup, GHAs look better now. @GoeLin, please see the pending request for approval :)

@shipilev
Copy link
Member Author

The testing is clean. The push approval is there.

/integrate

@openjdk
Copy link

openjdk bot commented Apr 25, 2023

Going to push as commit e6e6bed.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 24e91c1: 8302594: use-after-free in Node::destruct
  • d964229: 8302172: [JVMCI] HotSpotResolvedJavaMethodImpl.canBeInlined must respect ForceInline
  • 3e0e4f0: 8301338: Identical branch conditions in CompileBroker::print_heapinfo
  • ee63f83: 8296412: Special case infinite loops with unmerged backedges in IdealLoopTree::check_safepts
  • 1dee04a: 8278146: G1: Rework VM_G1Concurrent VMOp to clearly identify it as pause
  • a000b2d: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
  • f969f81: 8301998: Update HarfBuzz to 7.0.1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 25, 2023
@openjdk openjdk bot closed this Apr 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 25, 2023
@openjdk
Copy link

openjdk bot commented Apr 25, 2023

@shipilev Pushed as commit e6e6bed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8252990-unsafe-storestore branch May 2, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants