Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289735: UTIL_LOOKUP_PROGS fails on pathes with space #1298

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Apr 26, 2023

I had to do minor resolves in configure.ac and basic_tools.m4. But just contextual.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1298/head:pull/1298
$ git checkout pull/1298

Update a local copy of the PR:
$ git checkout pull/1298
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1298/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1298

View PR using the GUI difftool:
$ git pr show -t 1298

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1298.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bad6aa68e4d491e819ab22e91dd5d65bb094120e 8289735: UTIL_LOOKUP_PROGS fails on pathes with space Apr 26, 2023
@openjdk
Copy link

openjdk bot commented Apr 26, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 26, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289735: UTIL_LOOKUP_PROGS fails on pathes with space
8306976: UTIL_REQUIRE_SPECIAL warning on grep

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • b90d917: 8303130: Document required Accessibility permissions on macOS
  • 241c066: 8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior
  • 48632e5: 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument
  • 52324b5: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Apr 27, 2023

Hi @RealCLanger,
what is wrong with the tests?

@RealCLanger
Copy link
Contributor Author

Hi @RealCLanger, what is wrong with the tests?

In the initial run, the builds failed because GHA couldn't download some prerequisites. I restarted the failed tests only but then it only builds, tests are not running. I will run GHA again.

@RealCLanger
Copy link
Contributor Author

Adding follow up JDK-8306976 inline.

/issue add 8306976

@openjdk openjdk bot removed clean ready Pull request is ready to be integrated labels Apr 27, 2023
@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@RealCLanger
Adding additional issue to issue list: 8306976: UTIL_REQUIRE_SPECIAL warning on grep.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 27, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 28, 2023

Going to push as commit b2f16a5.
Since your change was applied there have been 6 commits pushed to the master branch:

  • a485033: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging
  • 1ba2d53: 8305403: Shenandoah evacuation workers may deadlock
  • b90d917: 8303130: Document required Accessibility permissions on macOS
  • 241c066: 8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior
  • 48632e5: 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument
  • 52324b5: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 28, 2023
@openjdk openjdk bot closed this Apr 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 28, 2023
@openjdk
Copy link

openjdk bot commented Apr 28, 2023

@RealCLanger Pushed as commit b2f16a5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-bad6aa68 branch April 28, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants