Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior #1300

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 26, 2023

I backport this for parity with 17.0.8-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1300/head:pull/1300
$ git checkout pull/1300

Update a local copy of the PR:
$ git checkout pull/1300
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1300

View PR using the GUI difftool:
$ git pr show -t 1300

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1300.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cd77fcfb5f9156e5f0909fa15a842dde6c25c66a 8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior Apr 26, 2023
@openjdk
Copy link

openjdk bot commented Apr 26, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 26, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Apr 27, 2023

Pre-submit failure: bootjdk download failed. Unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Apr 27, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Apr 27, 2023

Going to push as commit 241c066.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 48632e5: 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument
  • 52324b5: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument
  • ac823d3: 8306664: GHA: Update MSVC version to latest stepping
  • da740fa: 8302595: use-after-free related to GraphKit::clone_map
  • 790802b: 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG
  • 394a756: 8254711: Add java.security.Provider.getService JFR Event

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 27, 2023
@openjdk openjdk bot closed this Apr 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 27, 2023
@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@GoeLin Pushed as commit 241c066.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant