-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297955: LDAP CertStore should use LdapName and not String for DNs #1303
Conversation
/issue JDK-8224768 |
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@GoeLin |
Marking as clean because this were two clean patches. |
@GoeLin This backport pull request is now marked as clean |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 96adf07.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.8-oracle.
I include test fix JDK-8224768 because that makes 8397955 apply clean. Also, 8224768 on it's own does not fix the Actalis test.
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1303/head:pull/1303
$ git checkout pull/1303
Update a local copy of the PR:
$ git checkout pull/1303
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1303/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1303
View PR using the GUI difftool:
$ git pr show -t 1303
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1303.diff
Webrev
Link to Webrev Comment