Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297955: LDAP CertStore should use LdapName and not String for DNs #1303

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 26, 2023

I backport this for parity with 17.0.8-oracle.

I include test fix JDK-8224768 because that makes 8397955 apply clean. Also, 8224768 on it's own does not fix the Actalis test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8297955: LDAP CertStore should use LdapName and not String for DNs
  • JDK-8224768: Test ActalisCA.java fails

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1303/head:pull/1303
$ git checkout pull/1303

Update a local copy of the PR:
$ git checkout pull/1303
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1303/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1303

View PR using the GUI difftool:
$ git pr show -t 1303

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1303.diff

Webrev

Link to Webrev Comment

@GoeLin
Copy link
Member Author

GoeLin commented Apr 26, 2023

/issue JDK-8224768

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport df9aad018a769a27221cb29e4e66465e5d98ba94 8297955: LDAP CertStore should use LdapName and not String for DNs Apr 26, 2023
@openjdk
Copy link

openjdk bot commented Apr 26, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 26, 2023
@openjdk
Copy link

openjdk bot commented Apr 26, 2023

@GoeLin
Adding additional issue to issue list: 8224768: Test ActalisCA.java fails.

@GoeLin
Copy link
Member Author

GoeLin commented Apr 26, 2023

Marking as clean because this were two clean patches.
/clean

@openjdk openjdk bot added the clean label Apr 26, 2023
@openjdk
Copy link

openjdk bot commented Apr 26, 2023

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Apr 26, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297955: LDAP CertStore should use LdapName and not String for DNs
8224768: Test ActalisCA.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 26, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented May 3, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 3, 2023

Going to push as commit 96adf07.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 65a02da: 8303476: Add the runtime version in the release file of a JDK image
  • 07993bf: 8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies
  • 5296357: 8303822: gtestMain should give more helpful output
  • aa8c46c: 8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr
  • b2f16a5: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space
  • a485033: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging
  • 1ba2d53: 8305403: Shenandoah evacuation workers may deadlock
  • b90d917: 8303130: Document required Accessibility permissions on macOS
  • 241c066: 8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior
  • 48632e5: 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument
  • ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/243e643076f70c2cfb480897e1640a21e7ac6552...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 3, 2023
@openjdk openjdk bot closed this May 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 3, 2023
@GoeLin GoeLin deleted the goetz_backport_8224768 branch May 3, 2023 08:37
@openjdk
Copy link

openjdk bot commented May 3, 2023

@GoeLin Pushed as commit 96adf07.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant