Skip to content

8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 27, 2023

Clean backport to fix the incubating Vector API. This unblocks testing of those APIs in latest LTS. Yes, I understand this is awkward to backport fixes for incubating features, but this one seems to be very easy to fix, and it was already found in real test deployment.

Additional testing:

  • Linux x86_64 fastdebug, jdk/incubator/vector compiler/vectorapi
  • Linux AArch64 fastdebug, jdk/incubator/vector compiler/vectorapi

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1305/head:pull/1305
$ git checkout pull/1305

Update a local copy of the PR:
$ git checkout pull/1305
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1305/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1305

View PR using the GUI difftool:
$ git pr show -t 1305

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1305.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 27, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c3ff151457102cd45e3c7a49a235a04066beca60 8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr Apr 27, 2023
@openjdk
Copy link

openjdk bot commented Apr 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • b90d917: 8303130: Document required Accessibility permissions on macOS
  • 241c066: 8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior
  • 48632e5: 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument
  • 52324b5: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument
  • ac823d3: 8306664: GHA: Update MSVC version to latest stepping
  • da740fa: 8302595: use-after-free related to GraphKit::clone_map
  • 790802b: 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG
  • 394a756: 8254711: Add java.security.Provider.getService JFR Event
  • 243e643: 8306768: CodeCache Analytics reports wrong threshold
  • e132605: 8296545: C2 Blackholes should allow load optimizations
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/bf0606a9b735b555a860a99139c09c2bc1da1600...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 27, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 27, 2023

Webrevs

@shipilev
Copy link
Member Author

shipilev commented May 2, 2023

Push approval is here.

/integrate

@openjdk
Copy link

openjdk bot commented May 2, 2023

Going to push as commit aa8c46c.
Since your change was applied there have been 14 commits pushed to the master branch:

  • b2f16a5: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space
  • a485033: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging
  • 1ba2d53: 8305403: Shenandoah evacuation workers may deadlock
  • b90d917: 8303130: Document required Accessibility permissions on macOS
  • 241c066: 8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior
  • 48632e5: 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument
  • 52324b5: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument
  • ac823d3: 8306664: GHA: Update MSVC version to latest stepping
  • da740fa: 8302595: use-after-free related to GraphKit::clone_map
  • 790802b: 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG
  • ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/bf0606a9b735b555a860a99139c09c2bc1da1600...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 2, 2023
@openjdk openjdk bot closed this May 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 2, 2023
@openjdk
Copy link

openjdk bot commented May 2, 2023

@shipilev Pushed as commit aa8c46c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8301190-turkish-i branch May 2, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant