-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8286191: misc tests fail due to JDK-8285987 #1321
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
@@ -1,5 +1,5 @@ | |||
/* | |||
* Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved. | |||
* Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copyright reversion here seems wrong. Update: It's also part of the upstream change. So fine for the backport.
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8286191
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 8c54104.
Your commit was automatically rebased without conflicts. |
This is a required follow up of 8285987.
I dropped the changes to the ProblemLists because the tests
are not problem listed in 17.
I added imports to Platform.java because it does not compile.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1321/head:pull/1321
$ git checkout pull/1321
Update a local copy of the PR:
$ git checkout pull/1321
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1321/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1321
View PR using the GUI difftool:
$ git pr show -t 1321
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1321.diff
Webrev
Link to Webrev Comment