-
Notifications
You must be signed in to change notification settings - Fork 234
8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
b29cdd9 to
d68ad89
Compare
d68ad89 to
dcbda7e
Compare
223eb2f to
c11e6b8
Compare
tstuefe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8271506
git fetch https://git.openjdk.java.net/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 5d54bf5.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.3-oracle.
I had to adapt the tests: I removed one check from dynamicArchive/LambdaContainsOldInf.java.
This depends on JDK-8271506.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/133/head:pull/133$ git checkout pull/133Update a local copy of the PR:
$ git checkout pull/133$ git pull https://git.openjdk.java.net/jdk17u-dev pull/133/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 133View PR using the GUI difftool:
$ git pr show -t 133Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/133.diff