8297587: Upgrade JLine to 3.22.0

[GoeLin]

I backport this as one of the regular updates to external libs.

Some cleanups were applied to the jline sources in head:
8276641: Use blessed modifier order in jshell
8284209: Replace remaining usages of 'a the' in source code
These were not backported, but overwritten by the jline update:
It obviously resets such changes to the wording in the
upstream sources.
src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/TerminalBuilder.java
src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/WindowsAnsiWriter.java

src/jdk.internal.le/share/classes/module-info.java
Resolved due to context.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8297587: Upgrade JLine to 3.22.0

Reviewers

• Matthias Baesken (@MBaesken - Reviewer) ⚠️ Review applies to d2231e2c

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1331/head:pull/1331
$ git checkout pull/1331

Update a local copy of the PR:
$ git checkout pull/1331
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1331/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1331

View PR using the GUI difftool:
$ git pr show -t 1331

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1331.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (de19bbc2)
• 01: Full - Incremental (38b98c65)
• 00: Full (d2231e2c)

[MBaesken]

In jdk20u openjdk/jdk20u@6db9050

I see

src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/OSUtils.java

    private static boolean isTestCommandValid(String command) {
        return Files.isExecutable(Paths.get(command));
    }

where is this here ? is it not needed ?
Otherwise looks okay to me.

[GoeLin]

Hi Matthias,
the patch in 20u contains follow-up JDK-8304498 which brings this new method.
Maybe I should include that here, too. Makes the change more similar to the 20u one
and simplifies backporting to 11.

[GoeLin]

Hi Matthias,
the patch in 20u contains follow-up JDK-8304498 which brings this new method.
Maybe I should include that here, too. Makes the change more similar to the 20u one
and simplifies backporting to 11.

[MBaesken]

Thanks for explaining the difference to jdk20u .

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297587: Upgrade JLine to 3.22.0

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 6a84974: 8305690: [X86] Do not emit two REX prefixes in Assembler::prefix

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

Somehow the test hang. SAP nightly testing passed.

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[GoeLin]

/integrate

[openjdk]

Going to push as commit d5a2309.
Since your change was applied there have been 6 commits pushed to the master branch:

• 8656141: 8301216: ForkJoinPool invokeAll() ignores timeout
• 3f52961: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
• efa1786: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected
• d4467a7: 8307331: Correctly update line maps when class redefine rewrites bytecodes
• b9eca2d: 8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message
• 6a84974: 8305690: [X86] Do not emit two REX prefixes in Assembler::prefix

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit d5a2309.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.