8305690: [X86] Do not emit two REX prefixes in Assembler::prefix#1334
8305690: [X86] Do not emit two REX prefixes in Assembler::prefix#1334lgxbslgx wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back gli! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@lgxbslgx This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
The fix request was approved. Could I get your help to sponsor this patch? /integrate |
|
/sponsor |
|
Going to push as commit 6a84974. |
|
@DamonFool @lgxbslgx Pushed as commit 6a84974. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
@DamonFool Thanks for the sponsor! |
Hi all,
This patch prevents
Assembler::prefixfrom emitting twoREXprefixes.Low risk:
It is a corner case which is not triggered by the current code.
In order to avoid bugs in the future, it is good to backport it.
Thanks for taking the time to review.
Best Regards,
-- Guoxiong
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1334/head:pull/1334$ git checkout pull/1334Update a local copy of the PR:
$ git checkout pull/1334$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1334/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1334View PR using the GUI difftool:
$ git pr show -t 1334Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1334.diff
Webrev
Link to Webrev Comment