Skip to content

8305690: [X86] Do not emit two REX prefixes in Assembler::prefix#1334

Closed
lgxbslgx wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:lgxbslgx-backport-49726ee3
Closed

8305690: [X86] Do not emit two REX prefixes in Assembler::prefix#1334
lgxbslgx wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:lgxbslgx-backport-49726ee3

Conversation

@lgxbslgx
Copy link
Member

@lgxbslgx lgxbslgx commented May 8, 2023

Hi all,

This patch prevents Assembler::prefix from emitting two REX prefixes.

Low risk:
It is a corner case which is not triggered by the current code.
In order to avoid bugs in the future, it is good to backport it.

Thanks for taking the time to review.

Best Regards,
-- Guoxiong


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305690: [X86] Do not emit two REX prefixes in Assembler::prefix

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1334/head:pull/1334
$ git checkout pull/1334

Update a local copy of the PR:
$ git checkout pull/1334
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1334/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1334

View PR using the GUI difftool:
$ git pr show -t 1334

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1334.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 8, 2023

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 49726ee3a95023a912aacad0e3714eae146eed21 8305690: [X86] Do not emit two REX prefixes in Assembler::prefix May 8, 2023
@openjdk
Copy link

openjdk bot commented May 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 8, 2023
@openjdk
Copy link

openjdk bot commented May 8, 2023

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305690: [X86] Do not emit two REX prefixes in Assembler::prefix

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 8, 2023
@mlbridge
Copy link

mlbridge bot commented May 8, 2023

Webrevs

@lgxbslgx
Copy link
Member Author

lgxbslgx commented May 9, 2023

The fix request was approved. Could I get your help to sponsor this patch?

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

@lgxbslgx
Your change (at version d9fa739) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 9, 2023

Going to push as commit 6a84974.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 9, 2023
@openjdk openjdk bot closed this May 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

@DamonFool @lgxbslgx Pushed as commit 6a84974.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lgxbslgx
Copy link
Member Author

lgxbslgx commented May 9, 2023

@DamonFool Thanks for the sponsor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants