-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8307134: Add GTS root CAs #1335
Conversation
Co-authored-by: Andy Warner <awarner@google.com> Co-authored-by: Rajan Halade <rhalade@openjdk.org> Reviewed-by: mullan, rhalade
👋 Welcome back jiangli! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@jianglizhou This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should only need to update the checksum if JDK-8305975 & JDK-8304760 are applied first. It seems this change was instead altered to work around their absence, but the former is now in both 11u & 17u, and the latter is in 17u too.
- Update 'CHECKSUM'.
Yeah, thanks. Merged the PR and refreshed the CHECKSUM in VerifyCACerts.java. |
/integrate |
Going to push as commit 2dc22d6.
Your commit was automatically rebased without conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks correct now.
@jianglizhou Pushed as commit 2dc22d6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport to JDK 17u for parity with 17.0.9-oracle.
Merged conflicts and regenerated 'CHECKSUM' in test/jdk/sun/security/lib/cacerts/VerifyCACerts.java.
Verified both test/jdk/security/infra/java/security/cert/CertPathValidator/certification/GoogleCA.java and test/jdk/sun/security/lib/cacerts/VerifyCACerts.java pass with a testing JDK 17u binary.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1335/head:pull/1335
$ git checkout pull/1335
Update a local copy of the PR:
$ git checkout pull/1335
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1335/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1335
View PR using the GUI difftool:
$ git pr show -t 1335
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1335.diff
Webrev
Link to Webrev Comment