Skip to content

8284331: Add sanity check for signal handler modification warning. #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 8, 2023

Hi all,

This pull request contains a backport of JDK-8284331, commit 116763cb from the openjdk/jdk repository.

The commit being backported was authored by Kevin Walls on 29 Apr 2022 and was reviewed by David Holmes and Alex Menkov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284331: Add sanity check for signal handler modification warning.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1336/head:pull/1336
$ git checkout pull/1336

Update a local copy of the PR:
$ git checkout pull/1336
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1336/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1336

View PR using the GUI difftool:
$ git pr show -t 1336

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1336.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 8, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 116763cb5d58a7316b7bada689a0fa34a7250ee7 8284331: Add sanity check for signal handler modification warning. May 8, 2023
@openjdk
Copy link

openjdk bot commented May 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 8, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284331: Add sanity check for signal handler modification warning.

Reviewed-by: kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • d4467a7: 8307331: Correctly update line maps when class redefine rewrites bytecodes
  • b9eca2d: 8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message
  • 6a84974: 8305690: [X86] Do not emit two REX prefixes in Assembler::prefix

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 8, 2023
@mlbridge
Copy link

mlbridge bot commented May 8, 2023

Webrevs

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 8, 2023
@RealCLanger RealCLanger closed this May 9, 2023
@RealCLanger RealCLanger reopened this May 9, 2023
@RealCLanger RealCLanger changed the title 8284331: Add sanity check for signal handler modification warning. Backport 116763cb5d58a7316b7bada689a0fa34a7250ee7 May 9, 2023
@openjdk openjdk bot changed the title Backport 116763cb5d58a7316b7bada689a0fa34a7250ee7 8284331: Add sanity check for signal handler modification warning. May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 9, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 22, 2023

Going to push as commit 36c364d.
Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 22, 2023
@openjdk openjdk bot closed this May 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 22, 2023
@openjdk
Copy link

openjdk bot commented May 22, 2023

@RealCLanger Pushed as commit 36c364d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants