-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276058: Some swing test fails on specific CI macos system #1337
8276058: Some swing test fails on specific CI macos system #1337
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
/issue add JDK-8277407 |
@RealCLanger |
/clean |
@RealCLanger This backport pull request is now marked as clean |
/integrate |
Going to push as commit 4a0f0f4.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 4a0f0f4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of JDK-8276058, commit 91607436 from the openjdk/jdk repository.
The commit being backported was authored by Prasanta Sadhukhan on 18 Nov 2021 and was reviewed by Phil Race and Alexander Zuev.
It applied clean and I added the fix for JDK-8277407 as well, since bug6276188.java would fail to compile otherwise. Marking as clean.
Thanks!
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1337/head:pull/1337
$ git checkout pull/1337
Update a local copy of the PR:
$ git checkout pull/1337
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1337/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1337
View PR using the GUI difftool:
$ git pr show -t 1337
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1337.diff
Webrev
Link to Webrev Comment