Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276058: Some swing test fails on specific CI macos system #1337

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 9, 2023

Hi all,

This pull request contains a backport of JDK-8276058, commit 91607436 from the openjdk/jdk repository.

The commit being backported was authored by Prasanta Sadhukhan on 18 Nov 2021 and was reviewed by Phil Race and Alexander Zuev.

It applied clean and I added the fix for JDK-8277407 as well, since bug6276188.java would fail to compile otherwise. Marking as clean.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8276058: Some swing test fails on specific CI macos system
  • JDK-8277407: javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails to compile after JDK-8276058

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1337/head:pull/1337
$ git checkout pull/1337

Update a local copy of the PR:
$ git checkout pull/1337
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1337/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1337

View PR using the GUI difftool:
$ git pr show -t 1337

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1337.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 91607436b79126ccb999deaf38a98209dbfe6ec1 8276058: Some swing test fails on specific CI macos system May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 9, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276058: Some swing test fails on specific CI macos system
8277407: javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails to compile after JDK-8276058

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 398da7e: 8305088: SIGSEGV in Method::is_method_handle_intrinsic
  • 1970b63: 8304054: Linux: NullPointerException from FontConfiguration.getVersion in case no fonts are installed
  • 5b29c6e: 8304867: Explicitly disable dtrace for ppc builds
  • d5a2309: 8297587: Upgrade JLine to 3.22.0
  • 8656141: 8301216: ForkJoinPool invokeAll() ignores timeout
  • 3f52961: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
  • efa1786: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected
  • d4467a7: 8307331: Correctly update line maps when class redefine rewrites bytecodes
  • b9eca2d: 8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review and removed ready Pull request is ready to be integrated labels May 9, 2023
@mlbridge
Copy link

mlbridge bot commented May 9, 2023

Webrevs

@RealCLanger
Copy link
Contributor Author

/issue add JDK-8277407

@openjdk openjdk bot removed clean ready Pull request is ready to be integrated labels May 11, 2023
@openjdk
Copy link

openjdk bot commented May 11, 2023

@RealCLanger
Adding additional issue to issue list: 8277407: javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails to compile after JDK-8276058.

@RealCLanger
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean label May 11, 2023
@openjdk
Copy link

openjdk bot commented May 11, 2023

@RealCLanger This backport pull request is now marked as clean

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 11, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 22, 2023

Going to push as commit 4a0f0f4.
Since your change was applied there have been 26 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 22, 2023
@openjdk openjdk bot closed this May 22, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 22, 2023
@openjdk openjdk bot removed the rfr Pull request is ready for review label May 22, 2023
@openjdk
Copy link

openjdk bot commented May 22, 2023

@RealCLanger Pushed as commit 4a0f0f4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant