Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message #1339

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented May 9, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1339/head:pull/1339
$ git checkout pull/1339

Update a local copy of the PR:
$ git checkout pull/1339
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1339/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1339

View PR using the GUI difftool:
$ git pr show -t 1339

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1339.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ebba42ac52109ca036f2e721402c06afa8f455bb 8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 9, 2023
@mlbridge
Copy link

mlbridge bot commented May 9, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented May 10, 2023

Pre-submit failure: infra, unrelated
wget exited with exit code 4

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2023

Going to push as commit b9eca2d.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2023
@openjdk openjdk bot closed this May 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2023
@openjdk
Copy link

openjdk bot commented May 10, 2023

@MBaesken Pushed as commit b9eca2d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants