-
Notifications
You must be signed in to change notification settings - Fork 232
8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code #1344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code #1344
Conversation
|
👋 Welcome back ogillespie! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@olivergillespie This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
Please enable pre-submit checks on this repo, and backport to 20u. |
|
They're enabled now, but not sure how to re-trigger. Must 20 be done before 17? |
|
You can request both 17 and 20 at the same time, so just post a 20u PR. I don't actually know how to provoke a pre-submit run, but I'd try a merging your branch with master. |
|
Triggered the checks, and they're passing. The bug is approved for 17u backport. I created openjdk/jdk20u#79 for 20. |
|
Please add a /integrate comment and I'll sponsor. |
|
/integrate |
|
@olivergillespie |
|
/sponsor |
|
Going to push as commit 61c7351.
Your commit was automatically rebased without conflicts. |
|
@phohensee @olivergillespie Pushed as commit 61c7351. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport for 8307346
This would be clean, except 8280450 adds some inconsequential code immediately after the hunks in g1 and parallel for reporting task queue stats, which causes a trivial conflict.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1344/head:pull/1344$ git checkout pull/1344Update a local copy of the PR:
$ git checkout pull/1344$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1344/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1344View PR using the GUI difftool:
$ git pr show -t 1344Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1344.diff
Webrev
Link to Webrev Comment