-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8307128: Open source some drag and drop tests 4 #1360
Conversation
👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@Rudometov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 49 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Hi @Rudometov, I think the fix for the requires comes in related issue JDK-8307799. |
/issue add JDK-8307799 |
@Rudometov |
Thank you. I overlooked that one, will pay more attention in the future. |
Thanks for backporting all the tests. It's good to have them in 17, too! |
/integrate |
@Rudometov |
/sponsor |
Going to push as commit c581886.
Your commit was automatically rebased without conflicts. |
@phohensee @Rudometov Pushed as commit c581886. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport openjdk/jdk@9829424
https://bugs.openjdk.org/browse/JDK-8307128 Open source some drag and drop tests 4
Not clean as required quick fix for @requires
Without this fix mac reported error Error. Parse Exception: Invalid tag: requires(os
Clean backport (f2ee1fd) + fix for requires in MozillaDnDTest (6b0e89a), new tests, low risk
Checked on macOS x64, linux x64
Progress
Issues
@requires
clauseReviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1360/head:pull/1360
$ git checkout pull/1360
Update a local copy of the PR:
$ git checkout pull/1360
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1360/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1360
View PR using the GUI difftool:
$ git pr show -t 1360
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1360.diff
Webrev
Link to Webrev Comment