Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307128: Open source some drag and drop tests 4 #1360

Closed

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented May 17, 2023

Backport openjdk/jdk@9829424
https://bugs.openjdk.org/browse/JDK-8307128 Open source some drag and drop tests 4

Not clean as required quick fix for @requires
Without this fix mac reported error Error. Parse Exception: Invalid tag: requires(os

Clean backport (f2ee1fd) + fix for requires in MozillaDnDTest (6b0e89a), new tests, low risk
Checked on macOS x64, linux x64


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8307128: Open source some drag and drop tests 4
  • JDK-8307799: Newly added java/awt/dnd/MozillaDnDTest.java has invalid jtreg @requires clause

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1360/head:pull/1360
$ git checkout pull/1360

Update a local copy of the PR:
$ git checkout pull/1360
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1360/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1360

View PR using the GUI difftool:
$ git pr show -t 1360

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1360.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2023

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@Rudometov Rudometov changed the title Rudometov backport 98294242a94c611e2a713c2d520e59dd873ae4a0 Backport 98294242a94c611e2a713c2d520e59dd873ae4a0 May 17, 2023
@openjdk openjdk bot changed the title Backport 98294242a94c611e2a713c2d520e59dd873ae4a0 8307128: Open source some drag and drop tests 4 May 17, 2023
@openjdk
Copy link

openjdk bot commented May 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 17, 2023
@mlbridge
Copy link

mlbridge bot commented May 17, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented May 18, 2023

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307128: Open source some drag and drop tests 4
8307799: Newly added java/awt/dnd/MozillaDnDTest.java has invalid jtreg `@requires` clause

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

  • 57d0a7f: 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors
  • 436d96f: 8275287: Relax memory ordering constraints on updating instance class and array class counters
  • 50aabaa: 8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS
  • 861fe74: 8274615: Support relaxed atomic add for linux-aarch64
  • fe17568: 8307135: java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java failed
  • 464a32b: 8227060: Optimize safepoint cleanup subtask order
  • 6033871: 8306640: Open source several AWT TextArea related tests
  • 05b2ff4: 8308554: [17u] Fix commit of 8286191. vm.musl was not removed from ExternalEditorTest
  • 9c0afc5: 8306752: Open source several container and component AWT tests
  • 4caa421: 8306755: Open source few Swing JComponent and AbstractButton tests
  • ... and 39 more: https://git.openjdk.org/jdk17u-dev/compare/bf7cedabb4501d2556ed6d9a7710d64780ad6005...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 18, 2023
@GoeLin
Copy link
Member

GoeLin commented May 23, 2023

Hi @Rudometov, I think the fix for the requires comes in related issue JDK-8307799.
Please add that with the / issue command to this PR, and mention that you include that
in the JBS issue.
You should always check all relates-to issues of a change you backport before you label it with fix-request! Often they are needed, too.

@Rudometov
Copy link
Member Author

/issue add JDK-8307799

@openjdk
Copy link

openjdk bot commented May 23, 2023

@Rudometov
Adding additional issue to issue list: 8307799: Newly added java/awt/dnd/MozillaDnDTest.java has invalid jtreg @requires clause.

@Rudometov
Copy link
Member Author

Thank you. I overlooked that one, will pay more attention in the future.

@GoeLin
Copy link
Member

GoeLin commented May 25, 2023

Thanks for backporting all the tests. It's good to have them in 17, too!

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@Rudometov
Your change (at version 6b0e89a) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 25, 2023

Going to push as commit c581886.
Since your change was applied there have been 50 commits pushed to the master branch:

  • 14779b1: 8294717: (bf) DirectByteBuffer constructor will leak if allocating Deallocator or Cleaner fails with OOME
  • 57d0a7f: 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors
  • 436d96f: 8275287: Relax memory ordering constraints on updating instance class and array class counters
  • 50aabaa: 8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS
  • 861fe74: 8274615: Support relaxed atomic add for linux-aarch64
  • fe17568: 8307135: java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java failed
  • 464a32b: 8227060: Optimize safepoint cleanup subtask order
  • 6033871: 8306640: Open source several AWT TextArea related tests
  • 05b2ff4: 8308554: [17u] Fix commit of 8286191. vm.musl was not removed from ExternalEditorTest
  • 9c0afc5: 8306752: Open source several container and component AWT tests
  • ... and 40 more: https://git.openjdk.org/jdk17u-dev/compare/bf7cedabb4501d2556ed6d9a7710d64780ad6005...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 25, 2023
@openjdk openjdk bot closed this May 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@phohensee @Rudometov Pushed as commit c581886.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants